Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Feature-14678][Master][UI]Dependent task parameter passing #14702

Merged
merged 18 commits into from
Oct 25, 2023
Merged

[Feature-14678][Master][UI]Dependent task parameter passing #14702

merged 18 commits into from
Oct 25, 2023

Conversation

Orange-Summer
Copy link
Contributor

Purpose of the pull request

Dependent task parameter passing

close #14678

Brief change log

add relevant code in module dolphinscheduler-ui
add parameterPassing related code in module dolphinscheduler-master
modify docs

Verify this pull request

This change can be verified as follows:

Manually verified the change by testing locally.

@github-actions github-actions bot added UI ui and front end related backend document labels Aug 4, 2023
songjianet
songjianet previously approved these changes Aug 7, 2023
View reviewed changes
@codecov-commenter
Copy link

codecov-commenter commented Aug 7, 2023 •
edited
Loading

Codecov Report

Merging #14702 (80cf099) into dev (2350775) will decrease coverage by 0.03%.
The diff coverage is 0.00%.

❗ Current head 80cf099 differs from pull request most recent head aa32ac7. Consider uploading reports for the commit aa32ac7 to get more accurate results

@@             Coverage Diff              @@
##                dev   #14702      +/-   ##
============================================
- Coverage     39.02%   38.99%   -0.03%     
+ Complexity     4600     4599       -1     
============================================
  Files          1231     1231              
  Lines         43300    43327      +27     
  Branches       4792     4793       +1     
============================================
- Hits          16896    16894       -2     
- Misses        24526    24554      +28     
- Partials       1878     1879       +1
Files Coverage Δ
...scheduler/plugin/task/api/model/DependentItem.java 0.00% <ø> (ø)
...cheduler/plugin/task/api/utils/DependentUtils.java 76.92% <0.00%> (-11.32%) ⬇️
...k/dependent/DependentAsyncTaskExecuteFunction.java 0.00% <0.00%> (ø)
...cheduler/server/master/utils/DependentExecute.java 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

songjianet
songjianet previously approved these changes Aug 11, 2023
View reviewed changes
rickchengx
rickchengx previously approved these changes Aug 14, 2023
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Radeity
Copy link
Member

Radeity commented Aug 14, 2023

Hi @Orange-Summer , may I ask why we need **EndTimeMap?

@Orange-Summer
Copy link
Contributor Author

Orange-Summer commented Aug 14, 2023 •
edited
Loading

@Radeity

As it says in the docs https://github.com/apache/dolphinscheduler/blob/dev/docs/docs/en/guide/parameter/priority.md

If there are multiple parameters with non-empty values, select the value from the upstream task with the earliest completion time

I think it is possible for multiple dependencies to have parameters with the same name, so we need to save the end time for later comparison

@Orange-Summer
Copy link
Contributor Author

@songjianet @rickchengx
I made some changes before, could you please review them again?

Orange-Summer and others added 5 commits August 31, 2023 10:00
@Orange-Summer
Merge branch 'dev' into dependent-task-parameter-passing
e2a8433
@Orange-Summer
Merge branch 'dev' into dependent-task-parameter-passing
a966293 
# Conflicts:
#	docs/docs/en/guide/task/dependent.md
#	docs/docs/zh/guide/task/dependent.md
#	docs/img/tasks/demo/dependent_task01.png
#	docs/img/tasks/demo/dependent_task02.png
#	docs/img/tasks/demo/dependent_task03.png
#	dolphinscheduler-master/src/main/java/org/apache/dolphinscheduler/server/master/utils/DependentExecute.java
#	dolphinscheduler-ui/src/views/projects/task/components/node/types.ts
@Orange-Summer
Merge remote-tracking branch 'origin/dependent-task-parameter-passing…
a62bc61 
…' into dependent-task-parameter-passing
@Orange-Summer
refactor: Solve conflicts caused by merge
fcc0c45
@rickchengx
Merge branch 'dev' into dependent-task-parameter-passing
f0320ac
@sonarcloud
Copy link

sonarcloud bot commented Sep 15, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@Gallardot
Copy link
Member

Dolphinscheduler supports project-level parameters. Will the parameter passing feature also pass project-level parameters along with it?

@Orange-Summer
Copy link
Contributor Author

My understanding is that it only passes the output parameters of the dependent workflow or task

@sonarcloud
Copy link

sonarcloud bot commented Oct 25, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@lenboo lenboo merged commit 688f844 into apache:dev Oct 25, 2023
54 of 55 checks passed
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
@Orange-Summer @rickchengx
@lenboo @xdu-chenrj
[Feature-14678][Master][UI]Dependent task parameter passing (apache#1…
5e76468 
…4702)

* feat: dependent task parameter passing

* style: code format

* refactor: remove inappropriate log

* refactor: Modify unreasonable code structure

* refactor: Modify unreasonable code structure

* refactor: Solve conflicts caused by merge

---------

Co-authored-by: Rick Cheng <rickchengx@gmail.com>
Co-authored-by: BaoLiang <29528966+lenboo@users.noreply.github.com>
@liuchunhua liuchunhua mentioned this pull request Feb 27, 2024
Closed
3 tasks
@caishunfeng caishunfeng mentioned this pull request Mar 7, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Radeity Radeity Radeity left review comments

@lenboo lenboo lenboo approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@EricGao888 EricGao888 Awaiting requested review from EricGao888 EricGao888 is a code owner

@Amy0104 Amy0104 Awaiting requested review from Amy0104

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@zhuangchong zhuangchong Awaiting requested review from zhuangchong

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

@songjianet songjianet Awaiting requested review from songjianet songjianet is a code owner

@rickchengx rickchengx Awaiting requested review from rickchengx

Assignees

@Orange-Summer Orange-Summer

Labels
backend document ready-to-merge UI ui and front end related
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Master][UI] Dependent task parameter passing
8 participants
@Orange-Summer @codecov-commenter @Radeity @Gallardot @songjianet @lenboo @rickchengx @zhongjiajie