Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[RPC] Refactor the remote module. #14776

Merged
merged 2 commits into from
Aug 23, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Aug 21, 2023

Purpose of the pull request

close #14509

Brief change log

  • Remove dolphinscheduler-module
  • Add dolphinscheduler-extract module, change all rpc to new API

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun changed the title Add dolphinscheduler-remote-base [RPC] Refactor the remote module. Aug 21, 2023
@ruanwenjun ruanwenjun marked this pull request as draft August 21, 2023 06:57
@ruanwenjun ruanwenjun added improvement make more easy to user or prompt friendly feature new feature labels Aug 21, 2023
@ruanwenjun ruanwenjun added this to the 3.2.0 milestone Aug 21, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_refactorRpc branch 4 times, most recently from d4f3a0b to 0b9d4d9 Compare August 21, 2023 11:11
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_refactorRpc branch 4 times, most recently from 2bf930a to a3bcb3d Compare August 21, 2023 14:30
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_refactorRpc branch 6 times, most recently from eca3885 to 7b53548 Compare August 22, 2023 09:18
@codecov-commenter
Copy link

Codecov Report

Merging #14776 (afe00b2) into dev (70731a1) will decrease coverage by 0.13%.
The diff coverage is 6.76%.

❗ Current head afe00b2 differs from pull request most recent head 1f313aa. Consider uploading reports for the commit 1f313aa to get more accurate results

@@             Coverage Diff              @@
##                dev   #14776      +/-   ##
============================================
- Coverage     38.85%   38.72%   -0.13%     
+ Complexity     4685     4502     -183     
============================================
  Files          1289     1198      -91     
  Lines         44315    42660    -1655     
  Branches       4880     4757     -123     
============================================
- Hits          17219    16522     -697     
+ Misses        25196    24311     -885     
+ Partials       1900     1827      -73     
Files Changed Coverage Δ
.../dolphinscheduler/alert/rpc/AlertOperatorImpl.java 0.00% <0.00%> (ø)
...che/dolphinscheduler/alert/rpc/AlertRpcServer.java 0.00% <0.00%> (ø)
...scheduler/alert/service/AlertBootstrapService.java 44.96% <ø> (ø)
.../dolphinscheduler/api/aspect/CacheEvictAspect.java 3.92% <0.00%> (-1.21%) ⬇️
...inscheduler/api/controller/ExecutorController.java 17.94% <ø> (ø)
...low/instance/pause/pause/PauseExecuteFunction.java 0.00% <0.00%> (ø)
...tance/pause/pause/PauseExecuteFunctionBuilder.java 37.50% <0.00%> (ø)
...or/workflow/instance/stop/StopExecuteFunction.java 0.00% <0.00%> (ø)
...flow/instance/stop/StopExecuteFunctionBuilder.java 60.00% <0.00%> (ø)
...che/dolphinscheduler/api/k8s/K8sClientService.java 5.00% <0.00%> (ø)
... and 86 more

... and 100 files with indirect coverage changes

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Aug 22, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 5 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 55 Code Smells

2.4% 2.4% Coverage
1.1% 1.1% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ruanwenjun ruanwenjun marked this pull request as ready for review August 22, 2023 13:35
@Radeity Radeity self-requested a review August 22, 2023 13:38
@ruanwenjun ruanwenjun merged commit 55cc772 into apache:dev Aug 23, 2023
51 of 53 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_refactorRpc branch August 23, 2023 01:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend CI&CD feature new feature improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RPC] Refactor the remote module.
3 participants