-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-15036] [API] Fix task definition edit doesn't work #14801
Conversation
@sdhzwc Could u plz use English for PR descriptions? |
Sorry, my English is not very good |
Thanks for your contribution, I changed the content to English. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I have completed the modifications
Please fix ut
|
Codecov Report
@@ Coverage Diff @@
## dev #14801 +/- ##
============================================
- Coverage 39.02% 39.00% -0.02%
- Complexity 4600 4603 +3
============================================
Files 1231 1231
Lines 43300 43362 +62
Branches 4792 4794 +2
============================================
+ Hits 16896 16914 +18
- Misses 24526 24569 +43
- Partials 1878 1879 +1
... and 2 files with indirect coverage changes 📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more |
...-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/ProcessTaskRelationMapper.xml
Show resolved
Hide resolved
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
...pi/src/main/java/org/apache/dolphinscheduler/api/service/impl/TaskDefinitionServiceImpl.java
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
+1
LGTM
Kudos, SonarCloud Quality Gate passed! |
* [Bug] [task definition] 修复任务定义修改,工作流无法生效问题 * [Bug] [API] Fix task check apply * [BUG][API] fix updateTaskDefinition method ut * [BUG][API] fix updateTaskDefinition method code specification * [BUG][API] fix one task corresponds to multiple workflow problems * [BUG][API] queryProcessTaskRelationByTaskCodeAndTaskVersion method adjust * [BUG][API] fix updateTaskDefinition method update --------- Co-authored-by: David Zollo <dailidong66@gmail.com> Co-authored-by: 旺阳 <wang@lqwang.net> Co-authored-by: xiangzihao <460888207@qq.com>
* [Bug] [task definition] 修复任务定义修改,工作流无法生效问题 * [Bug] [API] Fix task check apply * [BUG][API] fix updateTaskDefinition method ut * [BUG][API] fix updateTaskDefinition method code specification * [BUG][API] fix one task corresponds to multiple workflow problems * [BUG][API] queryProcessTaskRelationByTaskCodeAndTaskVersion method adjust * [BUG][API] fix updateTaskDefinition method update --------- Co-authored-by: David Zollo <dailidong66@gmail.com> Co-authored-by: 旺阳 <wang@lqwang.net> Co-authored-by: xiangzihao <460888207@qq.com>
fix #15036
Problem description: All versions have the problem that task definition changes do not take effect in the workflow and vice versa. There are several points as follows:
2、Modify the task definition with a predecessor task, but it is not available in the workflow.
3、Switch the workflow version and modify the task definition, which is not available in the workflow.
Dynamic demonstration of before and after repair comparison:
Before Repair
二、After Repair