Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Improvement-15009][Parameter] Change project parameter value to text #15010

Merged
merged 2 commits into from
Nov 30, 2023
Merged

[Improvement-15009][Parameter] Change project parameter value to text #15010

merged 2 commits into from
Nov 30, 2023
+7 −3

Conversation

rickchengx
Copy link
Contributor

Purpose of the pull request

Brief change log

Change project parameter value form varchar to text

Verify this pull request

@rickchengx rickchengx self-assigned this Oct 11, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 11, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (f2d1466) 38.02% compared to head (f41ebb3) 38.02%.

❗ Current head f41ebb3 differs from pull request most recent head 7b08d7b. Consider uploading reports for the commit 7b08d7b to get more accurate results

Additional details and impacted files 
@@            Coverage Diff            @@
##                dev   #15010   +/-   ##
=========================================
  Coverage     38.02%   38.02%           
  Complexity     4645     4645           
=========================================
  Files          1279     1279           
  Lines         44505    44505           
  Branches       4800     4800           
=========================================
  Hits          16924    16924           
  Misses        25721    25721           
  Partials       1860     1860

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Radeity
Copy link
Member

Radeity commented Oct 11, 2023

Hi @rickchengx , please add upgrade script.

SbloodyS
SbloodyS previously approved these changes Oct 15, 2023
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx
Copy link
Contributor Author

Hi @rickchengx , please add upgrade script.

Sure

zhongjiajie
zhongjiajie requested changes Oct 19, 2023
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

3.2.0 had released, could we migration to 3.2.1 and add upgrade statement?

@rickchengx
Copy link
Contributor Author

3.2.0 had released, could we migration to 3.2.1 and add upgrade statement?

Sure. It seems that CI has errors (mysql schema check) that are not caused by this PR change. I am not familiar with this part.

ruanwenjun
ruanwenjun previously approved these changes Oct 21, 2023
View reviewed changes
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge improvement make more easy to user or prompt friendly labels Oct 21, 2023
Radeity
Radeity previously approved these changes Oct 21, 2023
View reviewed changes
@Radeity Radeity added this to the 3.2.1 milestone Oct 22, 2023
@Radeity Radeity added the 3.2.1 label Oct 22, 2023
@rickchengx rickchengx dismissed stale reviews from Radeity and ruanwenjun via 623bbe8 November 23, 2023 02:25
fuchanghai
fuchanghai approved these changes Nov 24, 2023
View reviewed changes
Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchanghai
Copy link
Member

@Radeity @ruanwenjun

@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 30, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zhongjiajie zhongjiajie merged commit b4cf1cc into apache:dev Nov 30, 2023
58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fuchanghai fuchanghai fuchanghai approved these changes

@zhongjiajie zhongjiajie zhongjiajie approved these changes

@Radeity Radeity Radeity left review comments

@ruanwenjun ruanwenjun ruanwenjun left review comments

@SbloodyS SbloodyS SbloodyS left review comments

Assignees

@rickchengx rickchengx

Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.

[Improvement][Parameter] Change project parameter value to text
7 participants
@rickchengx @codecov-commenter @Radeity @fuchanghai @zhongjiajie @SbloodyS @ruanwenjun