Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing Kyuubi type in UI #15051

Merged
merged 3 commits into from
Oct 21, 2023
Merged

Fix missing Kyuubi type in UI #15051

merged 3 commits into from
Oct 21, 2023

Conversation

zhaohehuhu
Copy link
Contributor

@zhaohehuhu zhaohehuhu commented Oct 19, 2023

Purpose of the pull request

Fix missing Kyuubi datasource in UI as the screen shown.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md
Screenshot 2023-10-20 at 10 07 41

@github-actions github-actions bot added the UI ui and front end related label Oct 19, 2023
@ruanwenjun
Copy link
Member

@zhaohehuhu Thanks for your pr, can you provide screenshots for this change?

@ruanwenjun ruanwenjun added the bug Something isn't working label Oct 19, 2023
@zhaohehuhu
Copy link
Contributor Author

@zhaohehuhu Thanks for your pr, can you provide screenshots for this change?

Added. Thanks.

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun added this to the 3.2.1 milestone Oct 20, 2023
@codecov-commenter
Copy link

codecov-commenter commented Oct 20, 2023

Codecov Report

Merging #15051 (0d94baf) into dev (37db913) will not change coverage.
The diff coverage is n/a.

❗ Current head 0d94baf differs from pull request most recent head 778689e. Consider uploading reports for the commit 778689e to get more accurate results

@@            Coverage Diff            @@
##                dev   #15051   +/-   ##
=========================================
  Coverage     38.95%   38.95%           
- Complexity     4599     4603    +4     
=========================================
  Files          1231     1231           
  Lines         43354    43354           
  Branches       4795     4793    -2     
=========================================
  Hits          16887    16887           
  Misses        24594    24594           
  Partials       1873     1873           

📣 We’re building smart automated test selection to slash your CI/CD build times. Learn more

@sonarcloud
Copy link

sonarcloud bot commented Oct 20, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@ruanwenjun ruanwenjun merged commit f0f12c9 into apache:dev Oct 21, 2023
54 of 55 checks passed
@ruanwenjun
Copy link
Member

Merged, thanks for your pr.

@SbloodyS SbloodyS added the 3.2.1 label Oct 22, 2023
xdu-chenrj pushed a commit to xdu-chenrj/dolphinscheduler that referenced this pull request Oct 30, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 bug Something isn't working ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants