Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement] Remove spring cache for dao #15184

Merged
merged 1 commit into from
Nov 24, 2023

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Nov 18, 2023

Purpose of the pull request

Since open cache is dangerous, will cause data incorrect, although we close cache by default, but this will not used anymore, this pr will removed this.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added the improvement make more easy to user or prompt friendly label Nov 18, 2023
@codecov-commenter
Copy link

codecov-commenter commented Nov 18, 2023

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (9c7ad6d) 37.91% compared to head (0f39ec1) 37.98%.

❗ Current head 0f39ec1 differs from pull request most recent head ed39c1e. Consider uploading reports for the commit ed39c1e to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15184      +/-   ##
============================================
+ Coverage     37.91%   37.98%   +0.06%     
+ Complexity     4638     4637       -1     
============================================
  Files          1281     1279       -2     
  Lines         44600    44539      -61     
  Branches       4813     4800      -13     
============================================
+ Hits          16911    16916       +5     
+ Misses        25837    25771      -66     
  Partials       1852     1852              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeCache branch 2 times, most recently from 4b989f1 to 2bb0cc9 Compare November 19, 2023 03:51
Copy link

Please retry analysis of this Pull-Request directly on SonarCloud.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_removeCache branch 3 times, most recently from 41a60d4 to 34a5eab Compare November 24, 2023 02:12
caishunfeng
caishunfeng previously approved these changes Nov 24, 2023
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng changed the title Remove spring cache for dao [Improvement] Remove spring cache for dao Nov 24, 2023
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@caishunfeng caishunfeng merged commit 1d23e4f into apache:dev Nov 24, 2023
@zhongjiajie
Copy link
Member

zhongjiajie commented Nov 24, 2023

FYI, /img/cache-evict.png file exists but not use, we should remove it. https://github.com/apache/dolphinscheduler/actions/runs/6976423434/job/18984854087

@ruanwenjun ruanwenjun deleted the dev_wenjun_removeCache branch November 24, 2023 07:50
@ruanwenjun
Copy link
Member Author

FYI, /img/cache-evict.png file exists but not use, we should remove it. https://github.com/apache/dolphinscheduler/actions/runs/6976423434/job/18984854087

Will be fixed by #15220

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.3.0 backend document improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants