-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Improvement] Remove spring cache for dao #15184
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15184 +/- ##
============================================
+ Coverage 37.91% 37.98% +0.06%
+ Complexity 4638 4637 -1
============================================
Files 1281 1279 -2
Lines 44600 44539 -61
Branches 4813 4800 -13
============================================
+ Hits 16911 16916 +5
+ Misses 25837 25771 -66
Partials 1852 1852 ☔ View full report in Codecov by Sentry. |
4b989f1
to
2bb0cc9
Compare
Please retry analysis of this Pull-Request directly on SonarCloud. |
41a60d4
to
34a5eab
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
34a5eab
to
ed39c1e
Compare
Kudos, SonarCloud Quality Gate passed! |
FYI, |
Will be fixed by #15220 |
Purpose of the pull request
Since open cache is dangerous, will cause data incorrect, although we close cache by default, but this will not used anymore, this pr will removed this.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md