Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Chore] Fix Information Leakage Vulnerability #15192

Merged
merged 1 commit into from
Nov 21, 2023
Merged

[Chore] Fix Information Leakage Vulnerability #15192

merged 1 commit into from
Nov 21, 2023

Conversation

SbloodyS
Copy link
Member

@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly backend minor Chore Chores about the project, like code clean, typo, etc. 3.2.1 labels Nov 21, 2023
@SbloodyS SbloodyS added this to the 3.2.1 milestone Nov 21, 2023
@SbloodyS SbloodyS self-assigned this Nov 21, 2023
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (cca1c4a) 37.93% compared to head (0301761) 37.91%.

❗ Current head 0301761 differs from pull request most recent head 359b1a7. Consider uploading reports for the commit 359b1a7 to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15192      +/-   ##
============================================
- Coverage     37.93%   37.91%   -0.02%     
+ Complexity     4668     4661       -7     
============================================
  Files          1278     1278              
  Lines         44874    44833      -41     
  Branches       4870     4845      -25     
============================================
- Hits          17021    16998      -23     
+ Misses        25999    25981      -18     
  Partials       1854     1854

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

github-advanced-security[bot]
github-advanced-security bot found potential problems Nov 21, 2023
View reviewed changes
...r-api/src/main/java/org/apache/dolphinscheduler/api/security/impl/AbstractAuthenticator.java
@@ -95,7 +95,7 @@
return result;
}

log.info("Session is created and sessionId is :{}.", sessionId);
log.info("Session is created, userName:{}.", user.getUserName());

Check failure

Code scanning / CodeQL

Log Injection High

This log entry depends on a
user-provided value
Loading
.
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Nov 21, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@SbloodyS SbloodyS merged commit 7308888 into apache:dev Nov 21, 2023
52 of 53 checks passed
@SbloodyS SbloodyS deleted the fix_security branch November 21, 2023 03:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@EricGao888 EricGao888 EricGao888 approved these changes

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

@caishunfeng caishunfeng Awaiting requested review from caishunfeng caishunfeng is a code owner

Assignees

@SbloodyS SbloodyS

Labels
3.2.1 backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Milestone
3.2.1
Development

Successfully merging this pull request may close these issues.
3 participants
@SbloodyS @codecov-commenter @EricGao888