Fix home page workflow instance miss status #15193
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
zhongjiajie,
EricGao888,
songjianet,
Amy0104,
caishunfeng,
SbloodyS and
zhuangchong
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_fixHomePage
branch
3 times, most recently
from
59ec820 to
3131fe0
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixHomePage
branch
from
3131fe0 to
870d365
Compare
songjianet
previously approved these changes
Nov 22, 2023
qingwli
reviewed
Nov 22, 2023
| return Result.success(defineUserDto); | ||
| public Result<WorkflowDefinitionCountVo> countDefinitionByUser(@Parameter(hidden = true) @RequestAttribute(value = Constants.SESSION_USER) User loginUser, | ||
| @RequestParam(value = "projectCode", required = false) Long projectCode) { | ||
| if (projectCode == null || projectCode == 0) { |
There was a problem hiding this comment.
Why this line needs check projectCode == 0, looks like logic is simily above
There was a problem hiding this comment.
Since if from home page the projectCode will be 0... this should be refactor.
There was a problem hiding this comment.
Have removed this logic.
| <select id="countWorkflowInstanceStateByProjectCodes" resultType="org.apache.dolphinscheduler.dao.model.WorkflowInstanceStatusCountDto"> | ||
| select state, count(0) as count | ||
| from t_ds_process_instance | ||
| where is_sub_process = 0 | ||
| <if test="startTime != null and endTime != null"> |
There was a problem hiding this comment.
Suggested change
| <if test="startTime != null and endTime != null"> | |
| <if test="startTime != null> |
ruanwenjun
force-pushed
the
dev_wenjun_fixHomePage
branch
from
870d365 to
1c227e8
Compare
Thanks for your review |
|
SonarCloud Quality Gate failed.
|
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md