Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Set the tenant as the owner in final stage #15256

Merged
merged 1 commit into from
Dec 1, 2023

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

If we set the tenant as the working directory owner, then the deploy user might not have permission to create command file.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added bug Something isn't working backend labels Dec 1, 2023
@ruanwenjun ruanwenjun requested review from caishunfeng and removed request for caishunfeng December 1, 2023 13:12
Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Dec 1, 2023

Codecov Report

Attention: 25 lines in your changes are missing coverage. Please review.

Comparison is base (71ee1f0) 38.08% compared to head (dd40fe0) 38.04%.

❗ Current head dd40fe0 differs from pull request most recent head 64ee4d6. Consider uploading reports for the commit 64ee4d6 to get more accurate results

Files Patch % Lines
...pache/dolphinscheduler/common/utils/FileUtils.java 0.00% 20 Missing ⚠️
...heduler/common/exception/FileOperateException.java 0.00% 4 Missing ⚠️
...sk/api/shell/BaseLinuxShellInterceptorBuilder.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15256      +/-   ##
============================================
- Coverage     38.08%   38.04%   -0.04%     
+ Complexity     4669     4661       -8     
============================================
  Files          1279     1280       +1     
  Lines         44553    44563      +10     
  Branches       4802     4799       -3     
============================================
- Hits          16967    16956      -11     
- Misses        25720    25739      +19     
- Partials       1866     1868       +2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Dec 1, 2023

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 2 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 2 Code Smells

0.0% 0.0% Coverage
26.9% 26.9% Duplication

idea Catch issues before they fail your Quality Gate with our IDE extension sonarlint SonarLint

@ruanwenjun ruanwenjun merged commit ef2e9c9 into apache:dev Dec 1, 2023
52 of 53 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixSetOwner branch January 6, 2024 13:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants