Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[HotFix] Fix TaskOutputParameterParser might OOM if meet a bad output param expression #15264

Merged
merged 1 commit into from
Dec 4, 2023

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@codecov-commenter
Copy link

codecov-commenter commented Dec 2, 2023

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (7bfc6dc) 38.07% compared to head (d6d2155) 38.05%.

❗ Current head d6d2155 differs from pull request most recent head faeaf13. Consider uploading reports for the commit faeaf13 to get more accurate results

Files Patch % Lines
...gin/task/api/parser/TaskOutputParameterParser.java 88.46% 1 Missing and 2 partials ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15264      +/-   ##
============================================
- Coverage     38.07%   38.05%   -0.02%     
+ Complexity     4669     4660       -9     
============================================
  Files          1280     1280              
  Lines         44568    44583      +15     
  Branches       4802     4803       +1     
============================================
- Hits          16968    16965       -3     
- Misses        25731    25749      +18     
  Partials       1869     1869              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_setTaskParamsMaxRows branch from 577082b to e0e8b56 Compare December 3, 2023 15:35
@Radeity Radeity changed the title [HotFix] Fix TaskOutputParameterParser might OOM if meed a bad output param expression [HotFix] Fix TaskOutputParameterParser might OOM if meet a bad output param expression Dec 4, 2023
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_setTaskParamsMaxRows branch from e0e8b56 to faeaf13 Compare December 4, 2023 09:28
Copy link

sonarcloud bot commented Dec 4, 2023

Please retry analysis of this Pull-Request directly on SonarCloud.

@ruanwenjun ruanwenjun merged commit db3d84b into apache:dev Dec 4, 2023
52 of 53 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_setTaskParamsMaxRows branch December 4, 2023 10:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants