Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Master] send ACK event timeout #15346

Merged
merged 3 commits into from
Dec 21, 2023
Merged

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@codecov-commenter
Copy link

codecov-commenter commented Dec 20, 2023

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (ce11674) 37.81% compared to head (f2119e5) 37.81%.

❗ Current head f2119e5 differs from pull request most recent head 29a2cfb. Consider uploading reports for the commit 29a2cfb to get more accurate results

Files Patch % Lines
...er/server/master/event/TaskResultEventHandler.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15346      +/-   ##
============================================
- Coverage     37.81%   37.81%   -0.01%     
  Complexity     4701     4701              
============================================
  Files          1304     1304              
  Lines         45217    45221       +4     
  Branches       4859     4859              
============================================
  Hits          17099    17099              
- Misses        26255    26259       +4     
  Partials       1863     1863              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Gallardot and others added 2 commits December 21, 2023 13:56
Co-authored-by: Wenjun Ruan <wenjun@apache.org>
Signed-off-by: Gallardot <gallardot@apache.org>
Copy link

sonarcloud bot commented Dec 21, 2023

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ruanwenjun ruanwenjun added ready-to-merge improvement make more easy to user or prompt friendly bug Something isn't working and removed improvement make more easy to user or prompt friendly labels Dec 21, 2023
@ruanwenjun ruanwenjun merged commit f8a44ff into apache:dev Dec 21, 2023
52 checks passed
@Gallardot Gallardot deleted the fix-slow-ack branch December 21, 2023 12:11
@zhongjiajie zhongjiajie added this to the 3.2.1 milestone Jan 30, 2024
Gallardot added a commit to Gallardot/dolphinscheduler that referenced this pull request Mar 14, 2024
Gallardot pushed a commit to Gallardot/dolphinscheduler that referenced this pull request Mar 14, 2024
[Bug][Master] send ACK event timeout (apache#15346)

See merge request logan/devops/apache/dolphinscheduler!9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug][Master] send ACK event timeout
4 participants