[Improvement][K8S] Custom label of a K8S task can be passed to the pod

[Gallardot]

Purpose of the pull request

• close [Improvement][K8S] Custom label of a K8S task can be passed to the pod #15368

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

[codecov-commenter]

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (d6dea46) 38.13% compared to head (68f77f8) 38.11%.

❗ Current head 68f77f8 differs from pull request most recent head 37f941c. Consider uploading reports for the commit 37f941c to get more accurate results

Additional details and impacted files

@@             Coverage Diff              @@
##                dev   #15369      +/-   ##
============================================
- Coverage     38.13%   38.11%   -0.02%     
+ Complexity     4698     4697       -1     
============================================
  Files          1300     1300              
  Lines         44775    44778       +3     
  Branches       4800     4800              
============================================
- Hits          17073    17068       -5     
- Misses        25848    25858      +10     
+ Partials       1854     1852       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[sonarcloud]

Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

[fuchanghai]

hi @Gallardot I suggest that the following statement be executed at the end, so that when the user customizes the same label name, the one in ds will prevail, because ds will need to perform other operations with this label in the future. WDYT? cc @Radeity

jobLabelMap.put(LAYER_LABEL, LAYER_LABEL_VALUE);
jobLabelMap.put(NAME_LABEL, k8sJobName);

[Radeity]

We should keep user-defined labels higher priority. If it's conflict with some ds' future feature, we can add some check during task definition or throw run-time exception during task execution. Anyway, now it just behaves like identifier, like label job-name for pod which is auto-labeled by Kubernetes controller, current order is reasonable for me.