[HotFix] Fix createTaskInstanceWorkingDirectory failed if the old path exist #15377
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
from
0f6c407
to
5747436
Compare
SbloodyS
previously approved these changes
Jan 3, 2024
fuchanghai
requested changes
Jan 3, 2024
| try { | ||
| // Test if the working directory is exist | ||
| // will delete it and recreate | ||
| Files.createDirectory(Paths.get(taskWorkingDirectory)); |
There was a problem hiding this comment.
hi @ruanwenjun plz use Files.createDirectories to ensure that cascade creation does not report errors
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
from
b8f1734
to
519177b
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15377 +/- ##
=========================================
Coverage 38.03% 38.04%
+ Complexity 4691 4688 -3
=========================================
Files 1304 1304
Lines 44771 44770 -1
Branches 4799 4799
=========================================
+ Hits 17027 17031 +4
+ Misses 25893 25888 -5
Partials 1851 1851 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
from
519177b
to
7c3ba47
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix
Files.deleteIfExistscannot delete when the directory is not emptyBrief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md