Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][K8S]Optimize MDC for K8S tasks #15390

Merged
merged 9 commits into from
Jan 17, 2024

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@codecov-commenter
Copy link

codecov-commenter commented Jan 2, 2024

Codecov Report

Attention: 9 lines in your changes are missing coverage. Please review.

Comparison is base (603dfa2) 38.03% compared to head (8abf2a7) 38.02%.
Report is 1 commits behind head on dev.

❗ Current head 8abf2a7 differs from pull request most recent head 89b20ff. Consider uploading reports for the commit 89b20ff to get more accurate results

Files Patch % Lines
...uler/plugin/task/api/k8s/impl/K8sTaskExecutor.java 0.00% 9 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15390      +/-   ##
============================================
- Coverage     38.03%   38.02%   -0.01%     
  Complexity     4688     4688              
============================================
  Files          1304     1304              
  Lines         44777    44785       +8     
  Branches       4801     4801              
============================================
  Hits          17031    17031              
- Misses        25895    25903       +8     
  Partials       1851     1851              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@fuchanghai fuchanghai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fuchanghai fuchanghai added the improvement make more easy to user or prompt friendly label Jan 11, 2024
@fuchanghai fuchanghai added this to the 3.2.1 milestone Jan 11, 2024
@fuchanghai
Copy link
Member

@SbloodyS @zhuangchong @caishunfeng anyone have time to help review ?

Copy link

sonarcloud bot commented Jan 17, 2024

@fuchanghai fuchanghai merged commit c7a11ce into apache:dev Jan 17, 2024
56 checks passed
@Gallardot Gallardot deleted the fix-log-mdc branch February 21, 2024 09:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Improvement][K8S]Optimize MDC for K8S tasks
3 participants