Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature-15475][DinkyTask] DinkyTask supports Dinky-1.0.0 and common sql #15479

Merged
merged 5 commits into from
Jan 16, 2024

Conversation

aiwenmo
Copy link
Contributor

@aiwenmo aiwenmo commented Jan 12, 2024

Purpose of the pull request

DinkyTask supports Dinky-0.6.5~Dinky-1.0.0.
DinkyTask supports common sql task, such as mysql, doris, hive etc.
DinkyTask supports use local and global params as variables.
Dinky supports auto push task into dolphinscheduler and create workflow with dependent relation.

Brief change log

Update DinkyTask and logo.

Verify this pull request

It's a compatible change.

@aiwenmo
Copy link
Contributor Author

aiwenmo commented Jan 12, 2024

close #15475

@codecov-commenter
Copy link

codecov-commenter commented Jan 13, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (0b873e6) 38.04% compared to head (8b02d48) 38.03%.

❗ Current head 8b02d48 differs from pull request most recent head 86bcac1. Consider uploading reports for the commit 86bcac1 to get more accurate results

Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15479      +/-   ##
============================================
- Coverage     38.04%   38.03%   -0.01%     
+ Complexity     4688     4687       -1     
============================================
  Files          1304     1304              
  Lines         44770    44770              
  Branches       4799     4799              
============================================
- Hits          17031    17030       -1     
  Misses        25888    25888              
- Partials       1851     1852       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

songjianet
songjianet previously approved these changes Jan 15, 2024
@aiwenmo
Copy link
Contributor Author

aiwenmo commented Jan 15, 2024

Sonarcloud has two issues. I will fix it tonight. thx
Rename this local variable to match the regular expression '^[a-z][a-zA-Z0-9]*$'.

Copy link

sonarcloud bot commented Jan 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@zhuangchong zhuangchong added the feature new feature label Jan 16, 2024
@zhuangchong zhuangchong merged commit ace0860 into apache:dev Jan 16, 2024
57 of 58 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend feature new feature ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants