TaskGroupPriority only compare When TaskGroup is same #15486
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
from
a255d4d
to
f8ed640
Compare
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## dev #15486 +/- ##
=========================================
Coverage 38.02% 38.03%
- Complexity 4687 4688 +1
=========================================
Files 1304 1304
Lines 44786 44791 +5
Branches 4802 4803 +1
=========================================
+ Hits 17030 17035 +5
Misses 25904 25904
Partials 1852 1852 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
3 times, most recently
from
ccfbcdc
to
e67b417
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixDeleteWorkingDirectoryDev
branch
from
e67b417
to
c9a54e9
Compare
|
fuchanghai
approved these changes
Jan 18, 2024
| Long.compare(o1.getTaskInstancePriority().getCode(), o2.getTaskInstancePriority().getCode()); | ||
|
|
||
| if (o1.getTaskGroupId() == o2.getTaskGroupId()) { | ||
| // Is at the same taskGroup |
There was a problem hiding this comment.
hi @ruanwenjun Do we change it to If at the same taskGroup
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Fix taskGroup priority will be used as compare rule when the two task instance is not at the same queue
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md