Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Fix] fix switch js #15487

Merged
merged 3 commits into from
Feb 5, 2024
Merged

[Fix] fix switch js #15487

merged 3 commits into from
Feb 5, 2024

Conversation

caishunfeng
Copy link
Contributor

Purpose of the pull request

Brief change log

  • add black key check for switch expression.

Verify this pull request

Had updated UT

@caishunfeng caishunfeng self-assigned this Jan 15, 2024
@caishunfeng caishunfeng added the bug Something isn't working label Jan 15, 2024
@mergeable mergeable bot removed the bug Something isn't working label Jan 15, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jan 15, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (edbf5cd) 38.10% compared to head (85ebc3b) 38.13%.

❗ Current head 85ebc3b differs from pull request most recent head 301c70e. Consider uploading reports for the commit 301c70e to get more accurate results

Additional details and impacted files 
@@             Coverage Diff              @@
##                dev   #15487      +/-   ##
============================================
+ Coverage     38.10%   38.13%   +0.02%     
- Complexity     4698     4704       +6     
============================================
  Files          1304     1304              
  Lines         44818    44823       +5     
  Branches       4804     4806       +2     
============================================
+ Hits          17080    17093      +13     
+ Misses        25884    25874      -10     
- Partials       1854     1856       +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@caishunfeng caishunfeng changed the title [Bug] fix switch js [Fix] fix switch js Jan 15, 2024
rickchengx
rickchengx approved these changes Jan 29, 2024
View reviewed changes
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx added improvement make more easy to user or prompt friendly 3.2.1 security labels Jan 29, 2024
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Feb 5, 2024

Quality Gate Passed Quality Gate passed

The SonarCloud Quality Gate passed, but some issues were introduced.

1 New issue
0 Security Hotspots
100.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@rickchengx rickchengx merged commit ef9ed3d into apache:dev Feb 5, 2024
56 checks passed
zhongjiajie pushed a commit that referenced this pull request Feb 6, 2024
@caishunfeng @zhongjiajie
fix switch js (#15487)
ca93aa8 
Co-authored-by: Rick Cheng <rickchengx@gmail.com>
Co-authored-by: Eric Gao <ericgao.apache@gmail.com>
(cherry picked from commit ef9ed3d)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rickchengx rickchengx rickchengx approved these changes

@SbloodyS SbloodyS Awaiting requested review from SbloodyS SbloodyS is a code owner

@ruanwenjun ruanwenjun Awaiting requested review from ruanwenjun ruanwenjun is a code owner

@zhongjiajie zhongjiajie Awaiting requested review from zhongjiajie

Assignees

@caishunfeng caishunfeng

Labels
3.2.1 backend improvement make more easy to user or prompt friendly ready-to-merge security
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@caishunfeng @codecov-commenter @rickchengx @EricGao888