Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

merge schema 330 into 321 and change docs (#15582) #15586

Merged
merged 5 commits into from
Feb 8, 2024

Conversation

zhongjiajie
Copy link
Member

we merge 330 to 321 because we already release those in 3.2.1,
this pr is for data consistency

@zhongjiajie zhongjiajie marked this pull request as ready for review February 7, 2024 09:44
@zhongjiajie zhongjiajie self-assigned this Feb 7, 2024
@zhongjiajie zhongjiajie added the minor Chore Chores about the project, like code clean, typo, etc. label Feb 7, 2024
Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Comment on lines 1 to 16
/*
* Licensed to the Apache Software Foundation (ASF) under one or more
* contributor license agreements. See the NOTICE file distributed with
* this work for additional information regarding copyright ownership.
* The ASF licenses this file to You under the Apache License, Version 2.0
* (the "License"); you may not use this file except in compliance with
* the License. You may obtain a copy of the License at
*
* http://www.apache.org/licenses/LICENSE-2.0
*
* Unless required by applicable law or agreed to in writing, software
* distributed under the License is distributed on an "AS IS" BASIS,
* WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
* See the License for the specific language governing permissions and
* limitations under the License.
*/
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We can remove the post.sql since this will not be used.

@codecov-commenter
Copy link

codecov-commenter commented Feb 7, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (718a01b) 38.53% compared to head (9932d2b) 38.53%.

❗ Current head 9932d2b differs from pull request most recent head c09763b. Consider uploading reports for the commit c09763b to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15586   +/-   ##
=========================================
  Coverage     38.53%   38.53%           
  Complexity     4772     4772           
=========================================
  Files          1310     1310           
  Lines         44880    44880           
  Branches       4808     4808           
=========================================
  Hits          17294    17294           
  Misses        25704    25704           
  Partials       1882     1882           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 8, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

@zhongjiajie zhongjiajie added this to the 3.2.2 milestone Feb 8, 2024
@zhongjiajie zhongjiajie added the improvement make more easy to user or prompt friendly label Feb 8, 2024
@zhongjiajie zhongjiajie merged commit e3bef81 into apache:dev Feb 8, 2024
62 of 63 checks passed
@zhongjiajie zhongjiajie deleted the sync-shema-change branch February 8, 2024 05:10
qingwli pushed a commit to qingwli/dolphinscheduler that referenced this pull request Feb 20, 2024
* merge schema 330 into 321 and change docs (apache#15582)

* Add 3.2.2 schema

* remove post sql
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly minor Chore Chores about the project, like code clean, typo, etc. ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants