Add link to ETCD/JDBC Registry Guideline #15597
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rickchengx
reviewed
Feb 20, 2024
EricGao888
reviewed
Feb 20, 2024
| @@ -187,6 +187,9 @@ The default configuration is as follows: | |||
|
|
|||
| Note that DolphinScheduler also supports zookeeper related configuration through `bin/env/dolphinscheduler_env.sh`. | |||
|
|
|||
| For ETCD Registry, please see more details on [link](https://github.com/apache/dolphinscheduler/blob/dev/dolphinscheduler-registry/dolphinscheduler-registry-plugins/dolphinscheduler-registry-etcd/README.md). | |||
There was a problem hiding this comment.
## Task Parameters
[//]: # (TODO: use the commented anchor below once our website template supports this syntax)
[//]: # (- Please refer to [DolphinScheduler Task Parameters Appendix](appendix.md#default-task-parameters) `Default Task Parameters` section for default parameters.)
This reminds me of an old issue. As the comment shows above, I'm wondering whether our website has supported markdown anchor? @zhongjiajie
EricGao888
previously approved these changes
Feb 20, 2024
EricGao888
reviewed
Feb 20, 2024
| @@ -162,9 +162,9 @@ The default configuration is as follows: | |||
|
|
|||
| Note that DolphinScheduler also supports database configuration through `bin/env/dolphinscheduler_env.sh`. | |||
|
|
|||
| ### Zookeeper related configuration | |||
| ### Registry related configuration | |||
There was a problem hiding this comment.
I think we should capitalize every word of a sub-title. Registry Related Configuration
Co-authored-by: Rick Cheng <rickchengx@gmail.com>
ruanwenjun
previously approved these changes
May 9, 2024
EricGao888
previously approved these changes
May 9, 2024
rickchengx
previously approved these changes
May 9, 2024
pegasas
dismissed stale reviews from rickchengx, EricGao888, and ruanwenjun
via
6c94eb3
|
Thanks, Done. |
rickchengx
approved these changes
May 9, 2024
|
I change the milestone to 3.2.2. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Add link to ETCD/JDBC Registry Guideline
fix #15591
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md