Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Improvement][API] add PageInfo UT #15622

Merged
merged 2 commits into from
Feb 26, 2024
Merged

[Improvement][API] add PageInfo UT #15622

merged 2 commits into from
Feb 26, 2024

Conversation

Gallardot
Copy link
Member

Purpose of the pull request

Add unit tests to improve code quality and robustness

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

Signed-off-by: Gallardot <gallardot@apache.org>
@SbloodyS SbloodyS added improvement make more easy to user or prompt friendly 3.2.2 labels Feb 26, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Feb 26, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 38.56%. Comparing base (e498116) to head (e722a05).

❗ Current head e722a05 differs from pull request most recent head 7a669b5. Consider uploading reports for the commit 7a669b5 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15622   +/-   ##
=========================================
  Coverage     38.56%   38.56%           
- Complexity     4788     4790    +2     
=========================================
  Files          1316     1316           
  Lines         45043    45043           
  Branches       4823     4823           
=========================================
+ Hits          17370    17372    +2     
+ Misses        25781    25780    -1     
+ Partials       1892     1891    -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Feb 26, 2024

@SbloodyS SbloodyS merged commit b278df1 into apache:dev Feb 26, 2024
56 checks passed
@Gallardot Gallardot deleted the pagingUT branch February 26, 2024 07:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 backend improvement make more easy to user or prompt friendly ready-to-merge
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants