[Bug] Fix task might be dispatched even if it has been killed #15662
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
force-pushed
the
dev_wenjun_fixKilledTaskWillBeDispatched
branch
from
22a2b0e
to
b4a7aba
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15662 +/- ##
============================================
+ Coverage 38.54% 38.61% +0.06%
- Complexity 4783 4791 +8
============================================
Files 1316 1316
Lines 44968 44969 +1
Branches 4816 4817 +1
============================================
+ Hits 17333 17363 +30
+ Misses 25755 25724 -31
- Partials 1880 1882 +2 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixKilledTaskWillBeDispatched
branch
5 times, most recently
from
aca4f61
to
beeb482
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixKilledTaskWillBeDispatched
branch
from
647c3df
to
f111449
Compare
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Close #15661
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md