Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-15698][UI] close the definition when opened in the new tab #15736

Merged
merged 2 commits into from
Mar 19, 2024

Conversation

arlendp
Copy link
Contributor

@arlendp arlendp commented Mar 19, 2024

Purpose of the pull request

fix #15698

workflow

Brief change log

edit router check when close the workflow definition opened in the new tab

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@github-actions github-actions bot added the UI ui and front end related label Mar 19, 2024
@arlendp
Copy link
Contributor Author

arlendp commented Mar 19, 2024

cc @rickchengx @SbloodyS

@SbloodyS SbloodyS added bug Something isn't working 3.2.2 labels Mar 19, 2024
@SbloodyS SbloodyS added this to the 3.2.2 milestone Mar 19, 2024
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 39.09%. Comparing base (1440045) to head (082db5e).

❗ Current head 082db5e differs from pull request most recent head e7e6229. Consider uploading reports for the commit e7e6229 to get more accurate results

Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15736   +/-   ##
=========================================
  Coverage     39.09%   39.09%           
  Complexity     4851     4851           
=========================================
  Files          1316     1316           
  Lines         44963    44963           
  Branches       4810     4810           
=========================================
  Hits          17579    17579           
  Misses        25485    25485           
  Partials       1899     1899           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 19, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit a16a15c into apache:dev Mar 19, 2024
59 of 60 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 bug Something isn't working ready-to-merge UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [UI] The 'Close' button is unresponsive in the new tab opened by clicking on the workflow name.
4 participants