Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug] Fix Switch logic task doesn't check the branch exist #15755

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Mar 22, 2024

Purpose of the pull request

close #15756

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixSwitchTaskDoenotCheckNode branch from 8320528 to 0976f12 Compare March 22, 2024 08:29
@ruanwenjun ruanwenjun added the bug Something isn't working label Mar 22, 2024
@mergeable mergeable bot removed the bug Something isn't working label Mar 22, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Mar 22, 2024
@ruanwenjun ruanwenjun added 3.2.1 bug Something isn't working labels Mar 22, 2024
@codecov-commenter
Copy link

codecov-commenter commented Mar 22, 2024

Codecov Report

Attention: Patch coverage is 0% with 42 lines in your changes are missing coverage. Please review.

Project coverage is 39.08%. Comparing base (2e16907) to head (f089692).

❗ Current head f089692 differs from pull request most recent head 0976f12. Consider uploading reports for the commit 0976f12 to get more accurate results

Files Patch % Lines
...master/runner/task/switchtask/SwitchLogicTask.java 0.00% 42 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##                dev   #15755   +/-   ##
=========================================
  Coverage     39.07%   39.08%           
- Complexity     4850     4852    +2     
=========================================
  Files          1316     1316           
  Lines         44965    44962    -3     
  Branches       4809     4808    -1     
=========================================
+ Hits          17572    17574    +2     
+ Misses        25492    25489    -3     
+ Partials       1901     1899    -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Mar 22, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit dcc9d64 into apache:dev Mar 24, 2024
59 of 60 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixSwitchTaskDoenotCheckNode branch May 31, 2024 13:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Switch task will not check if the node is exist.
3 participants