-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-15771] Fix normal user can grant project permission #15772
Conversation
Hi @silentxingtian , how about this method?
Looks like not checking is admin too. Could you fix this? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #15772 +/- ##
============================================
+ Coverage 39.09% 39.10% +0.01%
- Complexity 4850 4853 +3
============================================
Files 1316 1316
Lines 44936 44945 +9
Branches 4797 4800 +3
============================================
+ Hits 17567 17576 +9
Misses 25478 25478
Partials 1891 1891 ☔ View full report in Codecov by Sentry. |
ok, I will check all method and fix it |
i had fix grant project ,udf ,datasource method ,please check it again |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Generally LGTM. We should hide these options in the front-end UI as improvement.
@silentxingtian Please fix UT. |
this method need to add admin user check ,i had fix it. |
LGTM |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate passedIssues Measures |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Thanks for your first contribution. I'm looking forward to your deep participation.
* apache-dolphinscheduler/dev: [Fix-15771] Fix normal user can grant project permission (apache#15772)
Purpose of the pull request
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md