Bind processId to construct CodeGenerator #15848
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ruanwenjun
requested review from
caishunfeng,
SbloodyS and
EricGao888
as code owners
ruanwenjun
force-pushed
the
dev_wenjun_fixDuplicateCode
branch
from
a4ebcb0 to
031c3c4
Compare
EricGao888
reviewed
Apr 15, 2024
| @@ -1,4 +1,6 @@ | |||
| /** Copyright 2010-2012 Twitter, Inc.*/ | |||
| /** | |||
There was a problem hiding this comment.
This header looks unusual to me. Is it compatible with Apache 2.0?
There was a problem hiding this comment.
Since the origin code is copy from twitter, so need to announce it.
ruanwenjun
force-pushed
the
dev_wenjun_fixDuplicateCode
branch
from
12ec6fb to
22920e9
Compare
rickchengx
reviewed
Apr 15, 2024
ruanwenjun
force-pushed
the
dev_wenjun_fixDuplicateCode
branch
4 times, most recently
from
b441149 to
5092d32
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #15848 +/- ##
=========================================
Coverage 39.59% 39.59%
+ Complexity 5017 5011 -6
=========================================
Files 1347 1347
Lines 45646 45646
Branches 4892 4892
=========================================
+ Hits 18073 18074 +1
+ Misses 25649 25648 -1
Partials 1924 1924 ☔ View full report in Codecov by Sentry. |
ruanwenjun
force-pushed
the
dev_wenjun_fixDuplicateCode
branch
from
5092d32 to
f2eacef
Compare
ruanwenjun
force-pushed
the
dev_wenjun_fixDuplicateCode
branch
from
f2eacef to
62a7665
Compare
ruanwenjun
changed the title
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Right now the CodeGenerateUtils will not bind port, this means if we have multiple process which have the same host name, then these process will generate duplicate code.
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md