Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Forbidden forcess success a task instance in a running workflow instance #15855

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Apr 16, 2024

Purpose of the pull request

A simple way to avoid. close #15849

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_forbiddenForsuccessUnFinished branch from 9d7e95d to eb800ee Compare April 16, 2024 03:54
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_forbiddenForsuccessUnFinished branch from eb800ee to 25391f7 Compare April 16, 2024 03:56
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 16, 2024
@ruanwenjun ruanwenjun self-assigned this Apr 16, 2024
@ruanwenjun ruanwenjun added the bug Something isn't working label Apr 16, 2024
rickchengx
rickchengx previously approved these changes Apr 16, 2024
Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 55.00000% with 9 lines in your changes are missing coverage. Please review.

Project coverage is 39.56%. Comparing base (27d0563) to head (e8fa386).

❗ Current head e8fa386 differs from pull request most recent head 452299d. Consider uploading reports for the commit 452299d to get more accurate results

Files Patch % Lines
...uler/api/service/impl/TaskInstanceServiceImpl.java 60.00% 5 Missing and 1 partial ⚠️
...heduler/api/controller/TaskInstanceController.java 0.00% 2 Missing ⚠️
...nscheduler/service/process/ProcessServiceImpl.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15855      +/-   ##
============================================
- Coverage     39.59%   39.56%   -0.03%     
+ Complexity     5010     5009       -1     
============================================
  Files          1347     1347              
  Lines         45646    45629      -17     
  Branches       4892     4890       -2     
============================================
- Hits          18073    18053      -20     
- Misses        25648    25651       +3     
  Partials       1925     1925              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Apr 16, 2024

Please retry analysis of this Pull-Request directly on SonarCloud

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@ruanwenjun ruanwenjun merged commit 76d0598 into apache:dev Apr 16, 2024
59 of 60 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_forbiddenForsuccessUnFinished branch April 16, 2024 08:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] Force Success Invalid
4 participants