Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix kill dynamic task doesn't kill the wait to run workflow instances #15896

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

ruanwenjun
Copy link
Member

Purpose of the pull request

When we kill a DynamicTask, the commands should be deleted, and wait to run sub workflow instance should be kill.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this Apr 23, 2024
@ruanwenjun ruanwenjun added bug Something isn't working and removed backend labels Apr 23, 2024
@mergeable mergeable bot removed the bug Something isn't working label Apr 23, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Apr 23, 2024
@ruanwenjun ruanwenjun added bug Something isn't working priority:high labels Apr 23, 2024
@codecov-commenter
Copy link

codecov-commenter commented Apr 23, 2024

Codecov Report

Attention: Patch coverage is 0% with 36 lines in your changes are missing coverage. Please review.

Project coverage is 39.66%. Comparing base (1d13ef0) to head (1ad9011).

❗ Current head 1ad9011 differs from pull request most recent head 8bc89bd. Consider uploading reports for the commit 8bc89bd to get more accurate results

Files Patch % Lines
...r/master/runner/task/dynamic/DynamicLogicTask.java 0.00% 36 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15896      +/-   ##
============================================
- Coverage     39.78%   39.66%   -0.13%     
+ Complexity     5038     5013      -25     
============================================
  Files          1349     1349              
  Lines         45580    45615      +35     
  Branches       4890     4892       +2     
============================================
- Hits          18132    18091      -41     
- Misses        25532    25609      +77     
+ Partials       1916     1915       -1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Apr 25, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
0.0% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS added the 3.2.2 label Apr 25, 2024
@SbloodyS SbloodyS merged commit b3b8c07 into apache:dev Apr 25, 2024
61 of 62 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixKillDynamicTask branch May 31, 2024 13:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants