Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

EMR task support replace params placeholder #15975

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented May 10, 2024

Purpose of the pull request

Fix EMR task doesn't support use param placeholder in params.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun self-assigned this May 10, 2024
@ruanwenjun ruanwenjun added feature new feature bug Something isn't working and removed feature new feature labels May 10, 2024
@ruanwenjun ruanwenjun added this to the 3.2.2 milestone May 10, 2024
@codecov-commenter
Copy link

codecov-commenter commented May 10, 2024

Codecov Report

Attention: Patch coverage is 83.33333% with 2 lines in your changes are missing coverage. Please review.

Project coverage is 39.94%. Comparing base (ace20f9) to head (d0bce06).

❗ Current head d0bce06 differs from pull request most recent head 96b30e7. Consider uploading reports for the commit 96b30e7 to get more accurate results

Files Patch % Lines
...phinscheduler/plugin/task/emr/EmrAddStepsTask.java 83.33% 1 Missing ⚠️
...lphinscheduler/plugin/task/emr/EmrJobFlowTask.java 83.33% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #15975      +/-   ##
============================================
+ Coverage     39.86%   39.94%   +0.07%     
- Complexity     5060     5081      +21     
============================================
  Files          1369     1369              
  Lines         45635    45643       +8     
  Branches       4869     4869              
============================================
+ Hits          18193    18232      +39     
+ Misses        25544    25513      -31     
  Partials       1898     1898              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link

sonarcloud bot commented May 10, 2024

@EricGao888 EricGao888 merged commit 3446fd8 into apache:dev May 10, 2024
59 of 63 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixEMRDoesnotSuportParams branch May 31, 2024 13:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants