Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Chore] Disable discover composite indicator #16172

Merged

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 18, 2024

Purpose of the pull request

We don't use spring cloud discovery module, avoid get unknown discoveryComposite
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes Jun 18, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from 30099fe to 341a7a6 Compare June 18, 2024 02:40
@ruanwenjun ruanwenjun self-assigned this Jun 18, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from 341a7a6 to f847550 Compare June 18, 2024 05:30
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from f847550 to 7848e60 Compare June 18, 2024 15:27
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from 7848e60 to ae54fd5 Compare June 19, 2024 05:39
@ruanwenjun ruanwenjun requested a review from SbloodyS June 19, 2024 05:39
@ruanwenjun ruanwenjun added priority:low improvement make more easy to user or prompt friendly labels Jun 19, 2024
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from ae54fd5 to d4d411d Compare June 19, 2024 06:07
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_disableCompositeIndicator branch from f8213e5 to 6b5ba28 Compare June 19, 2024 09:01
@ruanwenjun ruanwenjun changed the title [Improvement] Disable discover composite indicator [Chore] Disable discover composite indicator Jun 19, 2024
Copy link

sonarcloud bot commented Jun 19, 2024

@ruanwenjun ruanwenjun merged commit 3f3f0cd into apache:dev Jun 20, 2024
64 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_disableCompositeIndicator branch June 20, 2024 02:09
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Jun 24, 2024
ruanwenjun added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend improvement make more easy to user or prompt friendly priority:low
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants