-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Chore] Disable discover composite indicator #16172
Merged
ruanwenjun
merged 1 commit into
apache:dev
from
ruanwenjun:dev_wenjun_disableCompositeIndicator
Jun 20, 2024
Merged
[Chore] Disable discover composite indicator #16172
ruanwenjun
merged 1 commit into
apache:dev
from
ruanwenjun:dev_wenjun_disableCompositeIndicator
Jun 20, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SbloodyS
previously approved these changes
Jun 18, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 18, 2024 02:40
30099fe
to
341a7a6
Compare
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 18, 2024 05:30
341a7a6
to
f847550
Compare
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 18, 2024 15:27
f847550
to
7848e60
Compare
EricGao888
approved these changes
Jun 19, 2024
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 19, 2024 05:39
7848e60
to
ae54fd5
Compare
ruanwenjun
added
priority:low
improvement
make more easy to user or prompt friendly
labels
Jun 19, 2024
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 19, 2024 06:07
ae54fd5
to
d4d411d
Compare
SbloodyS
approved these changes
Jun 19, 2024
ruanwenjun
force-pushed
the
dev_wenjun_disableCompositeIndicator
branch
from
June 19, 2024 09:01
f8213e5
to
6b5ba28
Compare
ruanwenjun
changed the title
[Improvement] Disable discover composite indicator
[Chore] Disable discover composite indicator
Jun 19, 2024
Quality Gate passedIssues Measures |
ruanwenjun
added a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Jun 24, 2024
(cherry picked from commit 3f3f0cd)
ruanwenjun
added a commit
that referenced
this pull request
Jun 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
We don't use spring cloud discovery module, avoid get unknown discoveryComposite
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md