-
Notifications
You must be signed in to change notification settings - Fork 4.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Fix-16191] Fix task cannot use workflow's environment #16199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM.
d83530c
to
656262f
Compare
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## dev #16199 +/- ##
============================================
- Coverage 41.01% 41.01% -0.01%
- Complexity 5149 5157 +8
============================================
Files 1399 1400 +1
Lines 44877 44860 -17
Branches 4759 4747 -12
============================================
- Hits 18407 18398 -9
+ Misses 24662 24656 -6
+ Partials 1808 1806 -2 ☔ View full report in Codecov by Sentry. |
51a4ec2
to
cfec149
Compare
cfec149
to
de6a34a
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Quality Gate failedFailed conditions |
(cherry picked from commit b34fe46)
(cherry picked from commit b34fe46)
Purpose of the pull request
close #16191
Brief change log
Verify this pull request
This pull request is code cleanup without any test coverage.
(or)
This pull request is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(or)
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md