Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16191] Fix task cannot use workflow's environment #16199

Merged
merged 1 commit into from
Jun 24, 2024

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 23, 2024

Purpose of the pull request

close #16191

Brief change log

  • Add EnvironmentUtils and WorkerGroupUtils to judge whether the environment and workergroup is empty

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

SbloodyS
SbloodyS previously approved these changes Jun 23, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

codecov-commenter commented Jun 24, 2024

Codecov Report

Attention: Patch coverage is 45.45455% with 18 lines in your changes missing coverage. Please review.

Project coverage is 41.01%. Comparing base (f0e0395) to head (0cfaf19).
Report is 1 commits behind head on dev.

Current head 0cfaf19 differs from pull request most recent head de6a34a

Please upload reports for the commit de6a34a to get more accurate results.

Files Patch % Lines
.../server/master/runner/WorkflowExecuteRunnable.java 0.00% 8 Missing ⚠️
...erver/master/runner/StreamTaskExecuteRunnable.java 0.00% 4 Missing ⚠️
...uler/server/master/registry/ServerNodeManager.java 0.00% 3 Missing ⚠️
...e/dolphinscheduler/dao/utils/EnvironmentUtils.java 80.00% 1 Missing ⚠️
...e/dolphinscheduler/dao/utils/WorkerGroupUtils.java 80.00% 1 Missing ⚠️
...cheduler/scheduler/quartz/ProcessScheduleTask.java 0.00% 1 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16199      +/-   ##
============================================
- Coverage     41.01%   41.01%   -0.01%     
- Complexity     5149     5157       +8     
============================================
  Files          1399     1400       +1     
  Lines         44877    44860      -17     
  Branches       4759     4747      -12     
============================================
- Hits          18407    18398       -9     
+ Misses        24662    24656       -6     
+ Partials       1808     1806       -2     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixTaskEnvironment branch 5 times, most recently from 51a4ec2 to cfec149 Compare June 24, 2024 10:22
@ruanwenjun ruanwenjun force-pushed the dev_wenjun_fixTaskEnvironment branch from cfec149 to de6a34a Compare June 24, 2024 11:06
@github-actions github-actions bot added the e2e e2e test label Jun 24, 2024
Copy link
Member

@Radeity Radeity left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link

sonarcloud bot commented Jun 24, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
50.9% Coverage on New Code (required ≥ 60%)

See analysis details on SonarCloud

@SbloodyS SbloodyS changed the title Fix task cannot use workflow's environment [Fix-16191] Fix task cannot use workflow's environment Jun 24, 2024
@SbloodyS SbloodyS merged commit b34fe46 into apache:dev Jun 24, 2024
63 of 64 checks passed
@SbloodyS SbloodyS added the 3.3.0 label Jun 24, 2024
@SbloodyS SbloodyS added this to the 3.3.0 milestone Jun 24, 2024
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixTaskEnvironment branch June 24, 2024 13:46
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Jun 24, 2024
@SbloodyS SbloodyS removed the 3.3.0 label Jun 24, 2024
@SbloodyS SbloodyS added the 3.2.2 label Jun 24, 2024
@SbloodyS SbloodyS modified the milestones: 3.3.0, 3.2.2 Jun 24, 2024
ruanwenjun added a commit to ruanwenjun/dolphinscheduler that referenced this pull request Jun 24, 2024
ruanwenjun added a commit that referenced this pull request Jun 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
4 participants