Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-16222] Fix worker overload will casue task failed #16221

Conversation

ruanwenjun
Copy link
Member

@ruanwenjun ruanwenjun commented Jun 26, 2024

Purpose of the pull request

close #16222

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(or)

Pull Request Notice

Pull Request Notice

If your pull request contain incompatible change, you should also add it to docs/docs/en/guide/upgrede/incompatible.md

@ruanwenjun ruanwenjun added this to the 3.2.2 milestone Jun 26, 2024
@ruanwenjun ruanwenjun added the bug Something isn't working label Jun 26, 2024
@ruanwenjun ruanwenjun self-assigned this Jun 26, 2024
@ruanwenjun ruanwenjun added 3.2.2 and removed backend labels Jun 26, 2024
@ruanwenjun ruanwenjun changed the title Fix worker overload will casue task failed [Fix-16221] Fix worker overload will casue task failed Jun 26, 2024
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@SbloodyS SbloodyS changed the title [Fix-16221] Fix worker overload will casue task failed [Fix-16222] Fix worker overload will casue task failed Jun 26, 2024
@codecov-commenter
Copy link

codecov-commenter commented Jun 26, 2024

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 41.24%. Comparing base (e856681) to head (604c79b).

Current head 604c79b differs from pull request most recent head 4a41e42

Please upload reports for the commit 4a41e42 to get more accurate results.

Files Patch % Lines
...duler/server/master/runner/BaseTaskDispatcher.java 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##                dev   #16221      +/-   ##
============================================
- Coverage     41.24%   41.24%   -0.01%     
+ Complexity     5125     5120       -5     
============================================
  Files          1397     1397              
  Lines         44056    44054       -2     
  Branches       4665     4666       +1     
============================================
- Hits          18173    18172       -1     
+ Misses        24103    24101       -2     
- Partials       1780     1781       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link

sonarcloud bot commented Jun 26, 2024

Copy link
Contributor

@rickchengx rickchengx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@rickchengx rickchengx merged commit 02bef74 into apache:dev Jun 27, 2024
66 of 67 checks passed
@ruanwenjun ruanwenjun deleted the dev_wenjun_fixWorkerOverloadWillCauseWorkerGroupNotFound branch November 23, 2024 22:42
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3.2.2 bug Something isn't working priority:high
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] Worker overload will cause task failed
4 participants