[Fix-16211] Remove ExecutePath in buildJarCommand to fix Java Task in Jar Mode #16238
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update JavaTask.java Fix buildJarCommand() ExecutePath already exist in ResourceAbsolutePath, no need to add it again
ResourceAbsolutePathInLocal contains the executePath, need update the Unit test accordingly. Also need this update for JavaTask buildJarCommand Change
lanxing2
requested review from
caishunfeng,
SbloodyS and
zhuangchong
as code owners
|
Changed the branch name and requested a new PR |
ruanwenjun
changed the title
|
Good catch, sorry for missing this, we can use directly abosolute path is enough. |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## dev #16238 +/- ##
============================================
- Coverage 41.18% 41.17% -0.02%
+ Complexity 5097 5096 -1
============================================
Files 1391 1391
Lines 43838 43837 -1
Branches 4652 4652
============================================
- Hits 18056 18050 -6
- Misses 24013 24018 +5
Partials 1769 1769 ☔ View full report in Codecov by Sentry. |
|
SbloodyS
changed the title
SbloodyS
changed the title
SbloodyS
changed the title
|
Awesome work, congrats on your first merged pull request! |
ruanwenjun
pushed a commit
to ruanwenjun/dolphinscheduler
that referenced
this pull request
Jun 29, 2024
… Jar Mode (apache#16238) (cherry picked from commit d42ac96)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Pull Request Branch
Issue-16211
Pull Request Content
Purpose of the pull request
Fix issue 16211
The comment says "duplicated with #15902"
And should be fixed by pr 15906
But I have tested and I think PR 15906 only fix the JavaTask Java Mode, Jar Mode still have bug
ResourceAbsolutePathInLocal already have the ExecutePath, need remove it in buildJarCommand() method
Also update the UnitTest
Please check my reply in issue 16211
I deployed the latest code in apache/dolphinscheduler dev branch in my own cluster and run JavaTask in Jar Mode and it failed
After deployed my code in my own cluster, run JavaTask in Jar Mode and it succeed
Brief change log
[Fix issue 16211] Remove ExecutePath in buildJarCommand() to fix Java Task in Jar Mode
Verify this pull request
This pull request is already covered by existing tests, such as (please describe tests).
(or)
Pull Request Code Style
Already run the mvn spotless:apply and checked no problem with the code style
Pull Request Notice
Pull Request Notice
If your pull request contain incompatible change, you should also add it to
docs/docs/en/guide/upgrede/incompatible.md