[Fix-8337] [Master] Process instance can not be kill when task is failure and can be retry #8347
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## 2.0.4-prepare #8347 +/- ##
================================================
Coverage ? 21.07%
Complexity ? 1589
================================================
Files ? 536
Lines ? 22492
Branches ? 2664
================================================
Hits ? 4740
Misses ? 17265
Partials ? 487 Continue to review full report at Codecov.
|
lenboo
reviewed
Feb 18, 2022
| @@ -134,6 +134,14 @@ private void checkTask4Retry() { | |||
| } | |||
|
|
|||
| for (TaskInstance taskInstance : this.taskInstanceRetryCheckList.values()) { | |||
| ProcessInstance processInstance = processService.findProcessInstanceById(taskInstance.getProcessInstanceId()); | |||
|
|
|||
| if (processInstance.getState() == ExecutionStatus.READY_STOP) { | |||
There was a problem hiding this comment.
This 'READY_STOP' state will be sent to master from API, so is it necessary to query from the database again？
|
SonarCloud Quality Gate failed.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix #8337