[Feature][Task] K8s namespace auth manager #9303
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
March 31, 2022 13:33
added 2 commits
March 31, 2022 13:55
Codecov Report
@@ Coverage Diff @@
## dev #9303 +/- ##
============================================
- Coverage 39.98% 39.71% -0.28%
- Complexity 4375 4411 +36
============================================
Files 822 826 +4
Lines 32924 33327 +403
Branches 3656 3698 +42
============================================
+ Hits 13165 13236 +71
- Misses 18532 18858 +326
- Partials 1227 1233 +6
Continue to review full report at Codecov.
|
caishunfeng
reviewed
Mar 31, 2022
...-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/K8SNamespaceServiceImpl.java
Outdated
Show resolved
Hide resolved
...heduler-dao/src/main/resources/org/apache/dolphinscheduler/dao/mapper/K8sNamespaceMapper.xml
Show resolved
Hide resolved
added 2 commits
April 2, 2022 11:11
|
The backend part is good to me. But you need to change UI in next-ui. @qianli2022 |
|
@songjianet please take a look of UI part, thanks. |
|
BTW, @qianli2022 please update the doc too, DS had put the doc part into code repository, so it should update the code and doc synchronously. |
|
There are two problems here:
|
|
Kudos, SonarCloud Quality Gate passed! |
|
PTAL again @songjianet the next-ui had added. |
|
The changes of the old ui can be reverted, because we will not do any non-bug processing on the old ui. |
fengjian1129
pushed a commit
to fengjian1129/dolphinscheduler
that referenced
this pull request
Apr 23, 2022
* k8s auth * remove log * fix test * use constants * use constants K8S_LOCAL_TEST_CLUSTER * simple auth get * change test * add namespace authorize in user page * prettier code * change test data Co-authored-by: qianl4 <qianl4@cicso.com> Co-authored-by: William Tong <weitong@cisco.com>
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Namespaces are managed with permissions that are created by the administrator and authorized to be used by ordinary users
Brief change log
Verify this pull request
This change added tests and can be verified as follows:
close #9252