[Fix-9352][datasource-api]data source client uses a cache with an expiration time #9353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #9353 +/- ##
============================================
+ Coverage 40.01% 40.06% +0.04%
- Complexity 4475 4482 +7
============================================
Files 835 835
Lines 33550 33599 +49
Branches 3710 3713 +3
============================================
+ Hits 13426 13462 +36
- Misses 18876 18887 +11
- Partials 1248 1250 +2
Continue to review full report at Codecov.
|
|
close #9352 |
|
LGTM |
zhongjiajie
reviewed
Apr 21, 2022
.../java/org/apache/dolphinscheduler/plugin/datasource/api/plugin/DataSourceClientProvider.java
Outdated
Show resolved
Hide resolved
dolphinscheduler-spi/src/main/java/org/apache/dolphinscheduler/spi/utils/Constants.java
Outdated
Show resolved
Hide resolved
zhongjiajie
previously approved these changes
Apr 23, 2022
There was a problem hiding this comment.
LGTM, @caishunfeng do you have time to take a look at this PR?
caishunfeng
reviewed
Apr 23, 2022
...eduler-task-datax/src/main/java/org/apache/dolphinscheduler/plugin/task/datax/DataxTask.java
Outdated
Show resolved
Hide resolved
.../java/org/apache/dolphinscheduler/plugin/datasource/api/plugin/DataSourceClientProvider.java
Show resolved
Hide resolved
caishunfeng
reviewed
Apr 24, 2022
.../java/org/apache/dolphinscheduler/plugin/datasource/api/plugin/DataSourceClientProvider.java
Outdated
Show resolved
Hide resolved
|
SonarCloud Quality Gate failed. |
Tianqi-Dotes
pushed a commit
to Tianqi-Dotes/dolphinscheduler
that referenced
this pull request
Jun 16, 2022
…iration time (apache#9353) * datasource client cache with expiration time * remove unused import * fixed unit test * fix * fix * fix * fix * fix * fix * fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
This pull request add a cache with an expiration time for all data source client
close #9352
Brief change log
use Guava Cache for data source client instead of ConcurrentHashMap
Verify this pull request
This pull request is already covered by existing tests, DatasourceUtilTest.testCheckConnection