[Bug][API-9364]fix ProcessInstance wrong alert group id #9383
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@caishunfeng PTAL, much appreciated. |
Codecov Report
@@ Coverage Diff @@
## dev #9383 +/- ##
============================================
- Coverage 39.98% 39.76% -0.22%
- Complexity 4375 4389 +14
============================================
Files 822 825 +3
Lines 32924 33176 +252
Branches 3656 3678 +22
============================================
+ Hits 13165 13194 +29
- Misses 18532 18750 +218
- Partials 1227 1232 +5
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
caishunfeng
approved these changes
Apr 7, 2022
caishunfeng
pushed a commit
to caishunfeng/dolphinscheduler
that referenced
this pull request
Apr 11, 2022
* fix ProcessInstance wrong alert group id * change createComplementCommandList method to protected
lenboo
pushed a commit
that referenced
this pull request
Apr 11, 2022
* [Fix][UI Next][V1.0.0-Alpha]Add zh for dag execution policy (#9363) * [Bug-9235][Alert]Fix wechat markdown message and change wechat form structure (#9367) * fix wechat issues: 1. change table msg type to markdown. 2. change userId to not required and enrich hints 3. change 'app id' to 'app id and chat id' * fix wechat issues: 1. revert table showtype and add markdown showtype. 2. enrich hints. 3. delete 'chatid', rename agentid to weChatAgentIdChatId. 4. modify code to send markdown message. * fix wechat issues: Change the language pack of agentId to agentId/chatId. * fix format * fix param name Co-authored-by: Amy <amywang0104@163.com> * [FIX-9355] Fix scheduleTime of start-process-instance api in api-doc (#9359) * fix #9355 * fix #9355 * fix ut error * fix ut error * [CI] try to fix ci (#9366) * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * try to fix ci * [optimization] [Service] Optimization ProcessService and add ProcessService interface (#9370) * [task-spark][docs] Corrected notice section (#9375) * [python] Migrate pythonGatewayServer into api server (#9372) Currently the size of our distribute package is up to 800MB, this patch is migrate python gateway server into api server The distribute package size before and after this patch is: ```sh # before 796M apache-dolphinscheduler-2.0.4-SNAPSHOT-bin.tar.gz # after 647M apache-dolphinscheduler-2.0.4-SNAPSHOT-bin.tar.gz ``` * [Fix][UI Next][V1.0.0-Alpha] Add light color theme to echarts. (#9381) * [Bug][API-9364]fix ProcessInstance wrong alert group id (#9383) * fix ProcessInstance wrong alert group id * change createComplementCommandList method to protected * [BUG][WORKER-9349]fix param priority (#9379) * fix param priority * fix params priority code logic * [Improvement] change method access (#9390) * change method to protected * change method access * [Fix-9221] [alert-server] optimization and gracefully close (#9246) * [Fix-9221] [alert-server] optimization and gracefully close This closes #9221 * [Fix-9221] [alert-server] remove unused mock data This closes #9221 * [Fix-9221] [alert-server] remove unused mock data This closes #9221 * [Fix-9221] [alert-server] remove unnecessary Mockito stubbings * [Fix-9221] [alert-server] init AlertPluginManager in AlertServer * [Fix-9221] [alert-server] AlertServerTest add AlertPluginManager installPlugin * [Fix-9221] [alert-server] replace @eventlistener with @PostConstruct * [Fix-9221] [alert-server] sonar check solution * [Improvement-9221] [alert] update constructor injection and replace IStoppable with Closeable Co-authored-by: guoshupei <guoshupei@lixiang.com> * [Fix][UI Next][V1.0.0-Alpha] Fix the task instance forced success button multi-language support error. (#9392) * [doc] Change get help from dev mail list to slack (#9377) * Change all get help from dev mailing list to slack, because we find out mailing list have many users ask for subscribe and they maybe subscribe by accident. * remove join dev mailing list in faq.md because we already have it in https://dolphinscheduler.apache.org/en-us/community/development/subscribe.html * Add new code owner of docs module (#9388) * [CI] Enable CI to remove unexpected files in /docs/img dir (#9393) * [Bug][UI Next]Modify the display state logic of save buttons under workflow definition (#9403) * Modifying site Configurations * Modify the display state logic of save buttons under workflow definition * [doc] Remove observability (#9402) SkyWalking v9 is coming soon and there are without DolphinScheduler menus anymore, So we should remove the SW agent to avoid confusion. close: #9242 * [DS-9387][refactor]Remove the lock in the start method of the MasterRegistryClient class (#9389) * [Fix-9251] [WORKER] reslove the sql task about of add the udf resource failed (#9319) * feat(resource manager): extend s3 to the storage of ds 1.fix some spell question 2.extend the type of storage 3.add the s3utils to manager resource 4.automatic inject the storage in addition to your config * fix(resource manager): update the dependency * fix(resource manager): extend s3 to the storage of ds fix the constant of hadooputils * fix(resource manager): extend s3 to the storage of ds 1.fix some spell question 2.delete the import * * fix(resource manager): merge the unitTest: 1.TenantServiceImpl 2.ResourceServiceImpl 3.UserServiceImpl * fix(resource manager): extend s3 to the storage of ds merge the resourceServiceTest * fix(resource manager): test cancel the test method createTenant verifyTenant * fix(resource manager): merge the code follow the check-result of sonar * fix(resource manager): extend s3 to the storage of ds fit the spell question * fix(resource manager): extend s3 to the storage of ds revert the common.properties * fix(resource manager): extend s3 to the storage of ds update the storageConfig with None * fix(resource manager): extend s3 to the storage of ds fix the judge of resourceType * fix(resource manager): extend s3 to the storage of ds undo the compile-mysql * fix(resource manager): extend s3 to the storage of ds delete hadoop aws * fix(resource manager): extend s3 to the storage of ds update the know-dependencies to delete aws 1.7.4 update the e2e file-manager common.properties * fix(resource manager): extend s3 to the storage of ds update the aws-region * fix(resource manager): extend s3 to the storage of ds fix the storageconfig init * fix(resource manager): update e2e docker-compose update e2e docker-compose * fix(resource manager): extend s3 to the storage of ds revent the e2e common.proprites print the resource type in propertyUtil * fix(resource manager): extend s3 to the storage of ds 1.println the properties * fix(resource manager): println the s3 info * fix(resource manager): extend s3 to the storage of ds delete the info and upgrade the s3 info to e2e * fix(resource manager): extend s3 to the storage of ds add the bucket init * fix(resource manager): extend s3 to the storage of ds 1.fix some spell question 2.delete the import * * fix(resource manager): extend s3 to the storage of ds upgrade the s3 endpoint * fix(resource manager): withPathStyleAccessEnabled(true) * fix(resource manager): extend s3 to the storage of ds 1.fix some spell question 2.delete the import * * fix(resource manager): upgrade the s3client builder * fix(resource manager): correct the s3 point to s3client * fix(resource manager): update the constant BUCKET_NAME * fix(resource manager): e2e s3 endpoint -> s3:9000 * fix(resource manager): extend s3 to the storage of ds 1.fix some spell question 2.delete the import * * style(resource manager): add info to createBucket * style(resource manager): debug the log * ci(resource manager): test test s3 * ci(ci): add INSERT INTO dolphinscheduler.t_ds_tenant (id, tenant_code, description, queue_id, create_time, update_time) VALUES(1, 'root', NULL, 1, NULL, NULL); to h2.sql * fix(resource manager): update the h2 sql * fix(resource manager): solve to delete the tenant * style(resource manager): merge the style end delete the unuse s3 config * fix(resource manager): extend s3 to the storage of ds UPDATE the rename resources when s3 * fix(resource manager): extend s3 to the storage of ds 1.fix the code style of QuartzImpl * fix(resource manager): extend s3 to the storage of ds 1.impoort restore_type to CommonUtils * fix(resource manager): update the work thread * fix(resource manager): update the baseTaskProcessor * fix(resource manager): upgrade dolphinscheduler-standalone-server.xml * fix(resource manager): add user Info to dolphinscheduler_h2.sql * fix(resource manager): merge the resourceType to NONE * style(upgrade the log level to info): * fix(resource manager): sysnc the h2.sql * fix(resource manager): update the merge the user tenant * fix(resource manager): merge the resourcesServiceImpl * fix(resource manager): when the storage is s3 ,that the directory can't be renamed * fix(resource manager): in s3 ,the directory cannot be renamed * fix(resource manager): delete the deleteRenameDirectory in E2E * fix(resource manager): check the style and recoverd the test * fix(resource manager): delete the log.print(LoginUser) * fix(server): fix the udf serialize * fix(master task): update the udfTest to update the json string * fix(test): update the udfFuncTest * fix(common): syn the common.properties * fix(udfTest): upgrade the udfTest * fix(common): revent the common.properties * [Fix-9316] [Task] Configure DB2 data source SQL script execution report ResultSet has been closed exception in SQL task (#9317) * fix db2 error in the sql task * update limit in sql task * [UI] Migrate NPM to PNPM in CI builds (#9431) Co-authored-by: Devosend <devosend@gmail.com> Co-authored-by: Tq <tianqitobethefirst@gmail.com> Co-authored-by: Amy <amywang0104@163.com> Co-authored-by: xiangzihao <460888207@qq.com> Co-authored-by: gaojun2048 <gaojun2048@gmail.com> Co-authored-by: mans2singh <mans2singh@users.noreply.github.com> Co-authored-by: Jiajie Zhong <zhongjiajie955@hotmail.com> Co-authored-by: Amy0104 <97265214+Amy0104@users.noreply.github.com> Co-authored-by: guoshupei <15764973965@163.com> Co-authored-by: guoshupei <guoshupei@lixiang.com> Co-authored-by: songjianet <1778651752@qq.com> Co-authored-by: Eric Gao <ericgao.apache@gmail.com> Co-authored-by: labbomb <739955946@qq.com> Co-authored-by: worry <7039986@qq.com> Co-authored-by: nobolity <nobolity@users.noreply.github.com> Co-authored-by: Kerwin <37063904+zhuangchong@users.noreply.github.com> Co-authored-by: kezhenxu94 <kezhenxu94@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
Refer to #9364
Brief change log
fix ProcessInstance wrong alert group id
Verify this pull request
I have tested this on local machine.