Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Future-9396]Support output parameters transfer from parent workflow to child work flow #9410

Merged
merged 2 commits into from
Apr 11, 2022
Merged

[Future-9396]Support output parameters transfer from parent workflow to child work flow #9410

merged 2 commits into from
Apr 11, 2022

Conversation

caishunfeng
Copy link
Contributor

Purpose of the pull request

this pr close #9396

Brief change log

Verify this pull request

  • Manually verified the change by testing locally.

@codecov-commenter
Copy link

codecov-commenter commented Apr 8, 2022 •
edited
Loading

Codecov Report

Merging #9410 (071511b) into dev (4a29c6a) will decrease coverage by 0.26%.
The diff coverage is 38.99%.

❗ Current head 071511b differs from pull request most recent head 5903a1c. Consider uploading reports for the commit 5903a1c to get more accurate results

@@             Coverage Diff              @@
##                dev    #9410      +/-   ##
============================================
- Coverage     39.98%   39.72%   -0.27%     
- Complexity     4375     4401      +26     
============================================
  Files           822      825       +3     
  Lines         32924    33219     +295     
  Branches       3656     3681      +25     
============================================
+ Hits          13165    13196      +31     
- Misses        18532    18796     +264     
  Partials       1227     1227
Impacted Files Coverage Δ
...lugin/alert/wechat/WeChatAlertParamsConstants.java 0.00% <ø> (ø)
...uler/plugin/alert/wechat/WechatAppChatMessage.java 0.00% <0.00%> (ø)
...cheduler/plugin/alert/wechat/WechatAppMessage.java 0.00% <0.00%> (ø)
...inscheduler/api/controller/ExecutorController.java 40.00% <ø> (ø)
...cheduler/api/service/impl/ExecutorServiceImpl.java 41.96% <ø> (ø)
...r/api/service/impl/ProcessInstanceServiceImpl.java 60.22% <ø> (-0.12%) ⬇️
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <ø> (+0.05%) ⬆️
.../org/apache/dolphinscheduler/common/Constants.java 80.95% <ø> (ø)
...che/dolphinscheduler/common/enums/AlertStatus.java 0.00% <0.00%> (ø)
...pache/dolphinscheduler/common/enums/AlertType.java 0.00% <0.00%> (ø)
... and 29 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 14d71d1...5903a1c. Read the comment docs.

@caishunfeng caishunfeng requested a review from lenboo April 8, 2022 14:58
@lenboo lenboo requested a review from wangxj3 April 8, 2022 16:08
SbloodyS
SbloodyS previously approved these changes Apr 9, 2022
View reviewed changes
Copy link
Member

@SbloodyS SbloodyS left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng requested a review from lenboo April 11, 2022 03:40
lenboo
lenboo previously approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@sonarqubecloud
Copy link

SonarCloud Quality Gate failed.    Quality Gate failed

Bug C 6 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 40 Code Smells

32.0% 32.0% Coverage
0.2% 0.2% Duplication

lenboo
lenboo approved these changes Apr 11, 2022
View reviewed changes
Copy link
Contributor

@lenboo lenboo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1

@lenboo lenboo merged commit b285ccf into apache:dev Apr 11, 2022
caishunfeng added a commit to caishunfeng/dolphinscheduler that referenced this pull request Apr 11, 2022
@caishunfeng
[Future-9396]Support output parameters transfer from parent workflow …
903a976 
…to child work flow (apache#9410)

* [Future-9396]Support output parameters transfer from parent workflow to child work flow

* fix note
lenboo pushed a commit that referenced this pull request Apr 11, 2022
@caishunfeng
[Future-9396]Support output parameters transfer from parent workflow …
9953e86 
…to child work flow (#9410) (#9442)

* [Future-9396]Support output parameters transfer from parent workflow to child work flow

* fix note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lenboo lenboo lenboo approved these changes

@SbloodyS SbloodyS SbloodyS left review comments

@wangxj3 wangxj3 Awaiting requested review from wangxj3

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Feature][Parameter Context] Support output parameters transfer from parent workflow to child work flow
4 participants
@caishunfeng @codecov-commenter @SbloodyS @lenboo