[Feature] [ALERT-9406]enrich alert info when insert new row into DB #9445
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## dev #9445 +/- ##
============================================
- Coverage 39.98% 39.70% -0.29%
- Complexity 4375 4398 +23
============================================
Files 822 825 +3
Lines 32924 33247 +323
Branches 3656 3683 +27
============================================
+ Hits 13165 13201 +36
- Misses 18532 18819 +287
Partials 1227 1227
Continue to review full report at Codecov.
|
|
SonarCloud Quality Gate failed. |
caishunfeng
reviewed
Apr 12, 2022
dolphinscheduler-common/src/main/java/org/apache/dolphinscheduler/common/enums/AlertType.java
Show resolved
Hide resolved
caishunfeng
approved these changes
Apr 12, 2022
Tianqi-Dotes
added a commit
to Tianqi-Dotes/dolphinscheduler
that referenced
this pull request
Jun 16, 2022
…pache#9445) * enrich alert info when insert new row into DB * fix comments
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
enrich alert info when inserting new row into DB
refer to #9406
refer to #9408
Brief change log
change property alertType from int to AlertType
and enrich new property infos when insert a new row
Verify this pull request
Have test locally.