-
Notifications
You must be signed in to change notification settings - Fork 4.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add ingress annotations #9492
Add ingress annotations #9492
Conversation
Codecov Report
@@ Coverage Diff @@
## dev #9492 +/- ##
============================================
+ Coverage 39.86% 39.89% +0.02%
Complexity 4415 4415
============================================
Files 826 826
Lines 33255 33258 +3
Branches 3683 3683
============================================
+ Hits 13257 13268 +11
+ Misses 18766 18759 -7
+ Partials 1232 1231 -1
Continue to review full report at Codecov.
|
Kudos, SonarCloud Quality Gate passed! |
Do you have time to take a look at this PR @kezhenxu94 |
Here's the test result, sorry it's late. 环境介绍DolphinScheduler 部署在 AKS,使用 ingress 暴露公网 IP。下面将公网 IP 隐去。 前后对比添加 IP 白名单前 Ingress yaml 文件
curl 访问 DS 登录页,返回 Status 200
values.yaml 增加 IP 白名单 ingress:
enabled: true
#host: "dolphinscheduler.org"
path: "/dolphinscheduler"
annotations:
nginx.ingress.kubernetes.io/whitelist-source-range: 192.168.1.0/8 ingress yaml 多了 annotations apiVersion: networking.k8s.io/v1
kind: Ingress
metadata:
name: dolphin
labels:
app.kubernetes.io/name: dolphin
app.kubernetes.io/instance: dolphin
app.kubernetes.io/managed-by: Helm
app.kubernetes.io/version: 1.3.9
annotations:
nginx.ingress.kubernetes.io/whitelist-source-range: 192.168.1.0/8
spec:
rules:
- host:
http:
paths:
- path: /dolphinscheduler
backend:
service:
name: dolphin-api
port:
name: api-port
pathType: Prefix
再次执行
|
Purpose of the pull request
This PR adds ingress annotations and is related to Issue #9486
Brief change log
Verify this pull request
Manually tested this pr by deploying DolphinScheduler to Azure CN K8S (AKS) with values.yaml.
And ip within the whitelist is allowed to access dolpinscheduler.
We're using nginx-ingress.
Here's ingress