Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][Next-UI] Fix the jumping problem of close button on dag page. #9494

Merged
merged 1 commit into from
Apr 14, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Apr 14, 2022

Purpose of the pull request

This pull request fixes the jumping problem of close button on dag page.

Related issues

close #9490

@codecov-commenter
Copy link

Codecov Report

Merging #9494 (0c7ad13) into dev (df791a3) will increase coverage by 0.03%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9494      +/-   ##
============================================
+ Coverage     39.86%   39.90%   +0.03%     
- Complexity     4415     4417       +2     
============================================
  Files           826      826              
  Lines         33255    33258       +3     
  Branches       3683     3683              
============================================
+ Hits          13257    13271      +14     
+ Misses        18766    18754      -12     
- Partials       1232     1233       +1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...che/dolphinscheduler/alert/AlertSenderService.java 54.33% <0.00%> (-0.07%) ⬇️
...org/apache/dolphinscheduler/alert/AlertServer.java 51.35% <0.00%> (ø)
...java/org/apache/dolphinscheduler/dao/AlertDao.java 31.45% <0.00%> (+5.52%) ⬆️
.../org/apache/dolphinscheduler/dao/entity/Alert.java 71.87% <0.00%> (+17.44%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update df791a3...0c7ad13. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 14, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 14, 2022
@mergeable mergeable bot removed bug Something isn't working UI ui and front end related labels Apr 14, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 14, 2022
@mergeable mergeable bot removed bug Something isn't working UI ui and front end related labels Apr 14, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 14, 2022
@mergeable mergeable bot removed bug Something isn't working UI ui and front end related labels Apr 14, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 14, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mergeable mergeable bot added bug Something isn't working UI ui and front end related and removed bug Something isn't working UI ui and front end related labels Apr 14, 2022
@songjianet songjianet merged commit 8a2fbd2 into apache:dev Apr 14, 2022
@Amy0104 Amy0104 deleted the fix-9490 branch June 27, 2022 06:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-FE] [UI Next][V1.0.0-Alpha] Repeated login problems
3 participants