Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI Next][V1.0.0-Beta] Added access to the child node function #9518

Merged
merged 3 commits into from
Apr 15, 2022
Merged

[Fix][UI Next][V1.0.0-Beta] Added access to the child node function #9518

merged 3 commits into from
Apr 15, 2022

Conversation

labbomb
Copy link
Member

@labbomb labbomb commented Apr 15, 2022

Purpose of the pull request

Please refer to the main issue #9461.

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added this to the 3.0.0-beta milestone Apr 15, 2022
@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 15, 2022
@songjianet songjianet linked an issue Apr 15, 2022 that may be closed by this pull request
3 tasks
@songjianet songjianet changed the title [Feature][UI Next]Added access to the child node function [Fix][UI Next][V1.0.0-Beta] Added access to the child node function Apr 15, 2022
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@codecov-commenter
Copy link

Codecov Report

Merging #9518 (e527096) into dev (1f48601) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9518   +/-   ##
=========================================
  Coverage     39.90%   39.91%           
- Complexity     4415     4417    +2     
=========================================
  Files           826      826           
  Lines         33253    33253           
  Branches       3683     3683           
=========================================
+ Hits          13270    13273    +3     
+ Misses        18752    18749    -3     
  Partials       1231     1231           
Impacted Files Coverage Δ
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 1f48601...e527096. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 15, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
7.9% 7.9% Duplication

Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 7777a6a into apache:dev Apr 15, 2022
@labbomb labbomb deleted the labbomb branch April 15, 2022 13:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-FE][UI Next][V1.0.0-Beta] Missing feature: Enter sub workflow
4 participants