Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI Next][V1.0.0-Beta] Fix the resource Center dark mode display exception when viewing the file details. #9526

Merged
merged 2 commits into from
Apr 16, 2022

Conversation

songjianet
Copy link
Member

@songjianet songjianet commented Apr 16, 2022

Purpose of the pull request

close #9508

image
image
image
image

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@songjianet songjianet added bug Something isn't working UI ui and front end related labels Apr 16, 2022
@songjianet songjianet added this to the 3.0.0-beta milestone Apr 16, 2022
@songjianet songjianet self-assigned this Apr 16, 2022
Copy link
Member

@Amy0104 Amy0104 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet changed the title Fix file edit theme [Fix][UI Next][V1.0.0-Beta] Fix the resource Center dark mode display exception when viewing the file details. Apr 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9526 (e1faaec) into dev (0972610) will increase coverage by 0.00%.
The diff coverage is n/a.

@@            Coverage Diff            @@
##                dev    #9526   +/-   ##
=========================================
  Coverage     39.90%   39.91%           
- Complexity     4416     4417    +1     
=========================================
  Files           826      826           
  Lines         33254    33254           
  Branches       3684     3684           
=========================================
+ Hits          13271    13272    +1     
  Misses        18752    18752           
+ Partials       1231     1230    -1     
Impacted Files Coverage Δ
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0972610...e1faaec. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

@songjianet songjianet merged commit 26726bb into apache:dev Apr 16, 2022
@songjianet songjianet deleted the fix-file-edit-theme branch April 24, 2022 02:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
4 participants