Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix-9525] [Worker] Environment did not work as expected #9527

Merged
merged 4 commits into from
Apr 16, 2022

Conversation

SbloodyS
Copy link
Member

Purpose of the pull request

This pr will close #9525

@songjianet songjianet added bug Something isn't working backend labels Apr 16, 2022
@codecov-commenter
Copy link

Codecov Report

Merging #9527 (0aa7412) into dev (0972610) will increase coverage by 0.01%.
The diff coverage is 100.00%.

@@             Coverage Diff              @@
##                dev    #9527      +/-   ##
============================================
+ Coverage     39.90%   39.91%   +0.01%     
- Complexity     4416     4418       +2     
============================================
  Files           826      826              
  Lines         33254    33252       -2     
  Branches       3684     3683       -1     
============================================
+ Hits          13271    13274       +3     
+ Misses        18752    18748       -4     
+ Partials       1231     1230       -1     
Impacted Files Coverage Δ
...olphinscheduler/plugin/task/python/PythonTask.java 9.58% <100.00%> (+0.25%) ⬆️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...r/plugin/task/sqoop/parameter/SqoopParameters.java 53.33% <0.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️
...er/master/dispatch/host/assign/RandomSelector.java 83.33% <0.00%> (+5.55%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0972610...0aa7412. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 16, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell D 2 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good job, LGTM.

@SbloodyS SbloodyS merged commit 7f41a96 into apache:dev Apr 16, 2022
@SbloodyS SbloodyS deleted the fix_9525 branch April 16, 2022 10:57
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
* fix apache#9525

* change to ${PYTHON_HOME}

* remove import

* fix ut error
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
backend bug Something isn't working
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Worker] Environment did not work as expected
4 participants