Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Docs] enhance alert doc #9534

Merged
merged 3 commits into from
Apr 20, 2022
Merged

[Docs] enhance alert doc #9534

merged 3 commits into from
Apr 20, 2022

Conversation

qingwli
Copy link
Member

@qingwli qingwli commented Apr 17, 2022

No description provided.

@qingwli
Copy link
Member Author

qingwli commented Apr 17, 2022

PTAL @zhongjiajie @CalvinKirs

@zhongjiajie zhongjiajie added enhancement New feature or request document labels Apr 19, 2022
zhongjiajie
zhongjiajie reviewed Apr 19, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I add some suggestions, others LGTM, especial the scenarios picture you add 👍

docs/docs/en/guide/alert/alert_plugin_user_guide.md Outdated Show resolved Hide resolved
docs/docs/en/development/backend/spi/alert.md Outdated Show resolved Hide resolved
docs/docs/zh/development/backend/spi/alert.md Show resolved Hide resolved
qE0a44OX6s and others added 2 commits April 19, 2022 15:43
@qE0a44OX6s @zhongjiajie
Update docs/docs/en/guide/alert/alert_plugin_user_guide.md
35bd9d4 
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
@qingwli
update
12c6fcd
zhongjiajie
zhongjiajie approved these changes Apr 20, 2022
View reviewed changes
Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks

@zhongjiajie zhongjiajie merged commit 6155dc3 into apache:dev Apr 20, 2022
fengjian1129 pushed a commit to fengjian1129/dolphinscheduler that referenced this pull request Apr 23, 2022
@qE0a44OX6s @zhongjiajie
[Docs] enhance alert doc (apache#9534)
2cfee52 
Co-authored-by: Jiajie Zhong <zhongjiajie955@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zhongjiajie zhongjiajie zhongjiajie approved these changes

Assignees

@qingwli qingwli

Labels
document enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@qingwli @zhongjiajie @qE0a44OX6s