[Bug] [API-9558]fix homepage task instance count method to use submit time to recount #9559
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
caishunfeng
reviewed
Apr 18, 2022
...-api/src/main/java/org/apache/dolphinscheduler/api/service/impl/DataAnalysisServiceImpl.java
Outdated
Show resolved
Hide resolved
Codecov Report
@@ Coverage Diff @@
## dev #9559 +/- ##
=========================================
Coverage 39.94% 39.95%
- Complexity 4429 4433 +4
=========================================
Files 831 831
Lines 33314 33338 +24
Branches 3677 3681 +4
=========================================
+ Hits 13308 13320 +12
- Misses 18781 18789 +8
- Partials 1225 1229 +4
Continue to review full report at Codecov.
|
|
Kudos, SonarCloud Quality Gate passed! |
caishunfeng
approved these changes
Apr 19, 2022
Tianqi-Dotes
added a commit
to Tianqi-Dotes/dolphinscheduler
that referenced
this pull request
Jun 16, 2022
… time to recount (apache#9559) * fix homepage task instance count method to use submit time to recount * fix homepage task instance count method to use submit time to recount * fix homepage task instance count method to use submit time to recount * fix homepage task instance count method JUNIT * fix homepage task instance count method JUNIT * fix homepage task instance count method JUNIT
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the pull request
fix homepage task instance count method to use submit time to recount special state
close #9558
Brief change log
fix homepage task instance count method to use submit time to recount special state
close #9558
Verify this pull request
I have tested locally.