Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Bug][Master] fix process pause and rerun #9568

Merged
merged 1 commit into from
Apr 19, 2022

Conversation

caishunfeng
Copy link
Contributor

@caishunfeng caishunfeng commented Apr 18, 2022

Purpose of the pull request

this pr close #9569

Brief change log

Verify this pull request

  • Manually verified the change by testing locally.

@codecov-commenter
Copy link

Codecov Report

Merging #9568 (f19f826) into dev (5529a23) will decrease coverage by 0.01%.
The diff coverage is 10.00%.

❗ Current head f19f826 differs from pull request most recent head 88607e8. Consider uploading reports for the commit 88607e8 to get more accurate results

@@             Coverage Diff              @@
##                dev    #9568      +/-   ##
============================================
- Coverage     39.95%   39.94%   -0.02%     
+ Complexity     4431     4430       -1     
============================================
  Files           831      831              
  Lines         33314    33326      +12     
  Branches       3677     3679       +2     
============================================
  Hits          13311    13311              
- Misses        18776    18788      +12     
  Partials       1227     1227              
Impacted Files Coverage Δ
...er/server/master/runner/WorkflowExecuteThread.java 8.25% <0.00%> (+0.03%) ⬆️
...nscheduler/service/process/ProcessServiceImpl.java 30.54% <0.00%> (-0.06%) ⬇️
...cheduler/api/service/impl/ExecutorServiceImpl.java 40.88% <15.38%> (-1.09%) ⬇️
.../org/apache/dolphinscheduler/api/enums/Status.java 100.00% <100.00%> (ø)
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5529a23...88607e8. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 18, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

12.1% 12.1% Coverage
0.0% 0.0% Duplication

Copy link
Member

@ruanwenjun ruanwenjun left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@caishunfeng caishunfeng merged commit 6363860 into apache:dev Apr 19, 2022
Tianqi-Dotes pushed a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug] [Master] process pause and recover fail
3 participants