Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Python] Make detached signature during release #9607

Merged
merged 1 commit into from
Apr 20, 2022

Conversation

zhuangchong
Copy link
Contributor

Purpose of the pull request

this pr close #9606

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

Merging #9607 (17f9e38) into dev (24e4553) will increase coverage by 0.00%.
The diff coverage is 31.25%.

❗ Current head 17f9e38 differs from pull request most recent head c9bec78. Consider uploading reports for the commit c9bec78 to get more accurate results

@@            Coverage Diff            @@
##                dev    #9607   +/-   ##
=========================================
  Coverage     39.96%   39.96%           
- Complexity     4436     4438    +2     
=========================================
  Files           831      832    +1     
  Lines         33337    33351   +14     
  Branches       3681     3683    +2     
=========================================
+ Hits          13324    13330    +6     
- Misses        18783    18787    +4     
- Partials       1230     1234    +4     
Impacted Files Coverage Δ
...che/dolphinscheduler/common/utils/HadoopUtils.java 30.39% <ø> (ø)
.../apache/dolphinscheduler/common/utils/S3Utils.java 0.00% <ø> (ø)
.../server/worker/processor/TaskExecuteProcessor.java 0.00% <0.00%> (ø)
...eduler/server/worker/runner/TaskExecuteThread.java 0.00% <0.00%> (ø)
...cheduler/common/storage/StorageOperateManager.java 38.46% <38.46%> (ø)
...er/master/dispatch/host/assign/RandomSelector.java 77.77% <0.00%> (-5.56%) ⬇️
...e/dolphinscheduler/common/enums/ResUploadType.java 100.00% <0.00%> (+100.00%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 930d120...c9bec78. Read the comment docs.

@zhuangchong zhuangchong requested a review from zhongjiajie April 20, 2022 05:02
@sonarqubecloud
Copy link

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@zhongjiajie zhongjiajie left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@zhongjiajie zhongjiajie merged commit 9d11be4 into apache:dev Apr 20, 2022
@zhongjiajie zhongjiajie changed the title [Feature][Python] make a detached signature [Python] Make detached signature during release Apr 20, 2022
@zhuangchong zhuangchong deleted the dev-python-dist-sign branch April 20, 2022 05:12
fengjian1129 pushed a commit to fengjian1129/dolphinscheduler that referenced this pull request Apr 23, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature][Python] make a detached signature
3 participants