Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix alert msg and change primitive to String to avoid wrong format #9689

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

Tianqi-Dotes
Copy link
Member

Purpose of the pull request

close #9687

Brief change log

close #9687

Verify this pull request

have test locally.

Copy link
Contributor

@caishunfeng caishunfeng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM if CI pass

@codecov-commenter
Copy link

Codecov Report

Merging #9689 (47f3f02) into dev (99678c0) will increase coverage by 0.03%.
The diff coverage is 17.64%.

@@             Coverage Diff              @@
##                dev    #9689      +/-   ##
============================================
+ Coverage     40.00%   40.03%   +0.03%     
- Complexity     4471     4475       +4     
============================================
  Files           835      835              
  Lines         33550    33550              
  Branches       3710     3710              
============================================
+ Hits          13421    13433      +12     
+ Misses        18881    18866      -15     
- Partials       1248     1251       +3     
Impacted Files Coverage Δ
...cheduler/api/service/impl/ExecutorServiceImpl.java 40.62% <0.00%> (ø)
...i/service/impl/ProcessTaskRelationServiceImpl.java 21.03% <0.00%> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <0.00%> (ø)
...heduler/api/service/impl/SchedulerServiceImpl.java 8.36% <20.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 31.07% <50.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 53.52% <0.00%> (+1.40%) ⬆️
...dolphinscheduler/remote/future/ResponseFuture.java 83.60% <0.00%> (+1.63%) ⬆️
...org/apache/dolphinscheduler/remote/utils/Host.java 40.00% <0.00%> (+2.22%) ⬆️
...r/plugin/registry/zookeeper/ZookeeperRegistry.java 55.35% <0.00%> (+7.14%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99678c0...47f3f02. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

17.6% 17.6% Coverage
5.9% 5.9% Duplication

@caishunfeng caishunfeng merged commit a51b710 into apache:dev Apr 24, 2022
Tianqi-Dotes added a commit to Tianqi-Dotes/dolphinscheduler that referenced this pull request Jun 16, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[BUG] [API] The alert format is wrong
3 participants