Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix][UI Next][V1.0.0-Beta] Fix the startup parameter display error. #9692

Merged
merged 2 commits into from
Apr 24, 2022

Conversation

Amy0104
Copy link
Member

@Amy0104 Amy0104 commented Apr 24, 2022

Purpose of the pull request

This pull request fixes the startup parameter display error.

Related issue

close #9674

@codecov-commenter
Copy link

codecov-commenter commented Apr 24, 2022

Codecov Report

Merging #9692 (8fb5b45) into dev (99678c0) will decrease coverage by 0.01%.
The diff coverage is 17.64%.

❗ Current head 8fb5b45 differs from pull request most recent head 95af5db. Consider uploading reports for the commit 95af5db to get more accurate results

@@             Coverage Diff              @@
##                dev    #9692      +/-   ##
============================================
- Coverage     40.01%   40.00%   -0.02%     
+ Complexity     4474     4472       -2     
============================================
  Files           835      835              
  Lines         33550    33550              
  Branches       3710     3710              
============================================
- Hits          13425    13421       -4     
- Misses        18876    18878       +2     
- Partials       1249     1251       +2     
Impacted Files Coverage Δ
...cheduler/api/service/impl/ExecutorServiceImpl.java 40.62% <0.00%> (ø)
...i/service/impl/ProcessTaskRelationServiceImpl.java 21.03% <0.00%> (ø)
...er/api/service/impl/TaskDefinitionServiceImpl.java 24.01% <0.00%> (ø)
...heduler/api/service/impl/SchedulerServiceImpl.java 8.36% <20.00%> (ø)
...api/service/impl/ProcessDefinitionServiceImpl.java 31.07% <50.00%> (ø)
...e/dolphinscheduler/remote/NettyRemotingClient.java 50.70% <0.00%> (-2.82%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 99678c0...95af5db. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

0.0% 0.0% Coverage
0.0% 0.0% Duplication

Copy link
Contributor

@devosend devosend left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@devosend devosend added bug Something isn't working UI ui and front end related labels Apr 24, 2022
@devosend devosend merged commit 3e85194 into apache:dev Apr 24, 2022
@Amy0104 Amy0104 deleted the fix/9674 branch May 10, 2022 05:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug-FE][UI Next][V1.0.0-Beta] Running the same workflow, the parameter displays an error in last one
3 participants