Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Feature]The utils configuration files are centrally managed under common #9706

Merged
merged 1 commit into from
Apr 24, 2022
Merged

Conversation

labbomb
Copy link
Member

@labbomb labbomb commented Apr 24, 2022

Purpose of the pull request

Brief change log

Verify this pull request

This pull request is code cleanup without any test coverage.

(or)

This pull request is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

@codecov-commenter
Copy link

Codecov Report

Merging #9706 (fe58825) into dev (48d526f) will decrease coverage by 0.01%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##                dev    #9706      +/-   ##
============================================
- Coverage     40.01%   40.00%   -0.02%     
+ Complexity     4475     4472       -3     
============================================
  Files           835      835              
  Lines         33550    33550              
  Branches       3710     3710              
============================================
- Hits          13426    13422       -4     
- Misses        18876    18881       +5     
+ Partials       1248     1247       -1     
Impacted Files Coverage Δ
...org/apache/dolphinscheduler/remote/utils/Host.java 37.77% <0.00%> (-2.23%) ⬇️
...dolphinscheduler/remote/future/ResponseFuture.java 81.96% <0.00%> (-1.64%) ⬇️
...e/dolphinscheduler/remote/NettyRemotingClient.java 52.11% <0.00%> (-1.41%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 48d526f...fe58825. Read the comment docs.

@sonarcloud
Copy link

sonarcloud bot commented Apr 24, 2022

SonarCloud Quality Gate failed.    Quality Gate failed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot E 1 Security Hotspot
Code Smell A 3 Code Smells

0.0% 0.0% Coverage
4.0% 4.0% Duplication

@songjianet songjianet added feature new feature UI ui and front end related labels Apr 24, 2022
@songjianet songjianet added this to the 3.0.0-beta milestone Apr 24, 2022
Copy link
Member

@songjianet songjianet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@songjianet songjianet merged commit 7382284 into apache:dev Apr 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
feature new feature UI ui and front end related
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants